-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added Factorial function #58
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good pending one comment, thanks for this addition.
Could you also add some unit tests for the parser (into parser_test_set.dart
) and the new expression (into expression_test_set.dart
)?
Ok, I think I added all tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding those tests, this looks good. They've surfaced a few more issues to fix but you're almost there :)
Co-authored-by: Frederik Leonhardt <[email protected]>
Co-authored-by: Frederik Leonhardt <[email protected]>
@Just-Learned-It Thanks for your contribution! Travis CI wasn't working with the new |
Glad I could help. I'm using the librabry myself so it's somewhat selfish :). Thanks for all the corrections. |
This is included in version 2.3.0 that I've just released to pub |
Provides one part of #26
The new Factorial function uses the symbol
!
and provides basic integer factorials. Non-integers are first rounded and then used as integers.