Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing SSL config to kafka admin clients #710

Merged
merged 6 commits into from
Nov 27, 2024
Merged

Add missing SSL config to kafka admin clients #710

merged 6 commits into from
Nov 27, 2024

Conversation

ppcad
Copy link
Collaborator

@ppcad ppcad commented Nov 21, 2024 •
edited
Loading

The SSL config was missing in the kafka admin client, which led to errors and failed health checks if SSL was used.

@ppcad ppcad requested a review from ekneg54 November 21, 2024 11:11
@ppcad ppcad self-assigned this Nov 21, 2024
ekneg54
ekneg54 requested changes Nov 22, 2024
View reviewed changes
Copy link
Collaborator

@ekneg54 ekneg54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this. Could you add tests that ensure this code won't get lost in future refactorings?

@ppcad ppcad requested a review from ekneg54 November 25, 2024 08:03
@ekneg54 ekneg54 merged commit af153a2 into main Nov 27, 2024
13 checks passed
@ekneg54 ekneg54 deleted the fix-ssl-config-for-kafka-admin branch November 27, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekneg54 ekneg54 ekneg54 approved these changes

Assignees

@ppcad ppcad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ppcad @ekneg54