Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/dll conflict #247

Merged
merged 3 commits into from
Feb 27, 2024
Merged

Fix/dll conflict #247

merged 3 commits into from
Feb 27, 2024

Conversation

xinyuli1204
Copy link
Contributor

@xinyuli1204 xinyuli1204 commented Feb 26, 2024

Conflict

In native.py

if platform.system() == 'Windows':
    ion_core_module = os.path.join(pre_built_path, 'windows/ion-core.dll')
    ion_bb_module = os.path.join(pre_built_path, 'windows/ion-bb.dll')

In builder.py

 if os.name == 'nt':
    ret = ion_builder_with_bb_module(self.obj, str(find_library(path)).encode())

ion_builder_with_bb_module will search sensing-dev-installed path first if we have already installed sensing-dev which has conflict with native.py if we want to load from prebuilt binary first

This was referenced Feb 26, 2024
@xinyuli1204 xinyuli1204 marked this pull request as ready for review February 26, 2024 20:42
@iitaku iitaku merged commit 17f645c into main Feb 27, 2024
3 checks passed
@xinyuli1204 xinyuli1204 changed the title fix dll conflict Fix/dll conflict May 7, 2024
@xinyuli1204 xinyuli1204 deleted the fix/windows-dll-import-conflict branch November 20, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants