Update/python binding api #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
xinyuli1204
commented
Jan 6, 2024
•
xinyuli1204
commented
- port binding api in python
- support python api in macOS
added 2 commits
January 5, 2024 19:27
iitaku
reviewed
Jan 6, 2024
python/ionpy/native.py
Outdated
| @@ -33,6 +37,7 @@ class c_builder_compile_option_t(ctypes.Structure): | |||
| c_ion_buffer_t = ctypes.POINTER(ctypes.c_int) | |||
| c_ion_port_map_t = ctypes.POINTER(ctypes.c_int) | |||
|
|
|||
| c_ion_port_bind_t = ctypes.POINTER(ctypes.c_int) | |||
python/ionpy/Port.py
Outdated
|
|
||
|
|
||
| # should use numpy type? | ||
| def bind_i8(self, v: int): |
There was a problem hiding this comment.
It is better design to provide a generic bind instead of type-specific method (e.g. bind_i8). The appropreate C-API can be determined by inspecting self.type and self.dim.
python/test/test_binding.py
Outdated
| from ionpy import Node, Builder, Buffer, PortMap, Port, Param, Type, TypeCode | ||
| import numpy as np # TODO: rewrite with pure python | ||
|
|
||
| def test_binding(): |
There was a problem hiding this comment.
Can you add a test case for scalar parameter bind?
python/test/test_binding.py
Outdated
| from ionpy import Node, Builder, Buffer, PortMap, Port, Param, Type, TypeCode | ||
| import numpy as np # TODO: rewrite with pure python | ||
|
|
||
| def test_binding(): |
There was a problem hiding this comment.
Can you replicate the C++ testcase for port binding using Python API? I want to keep the same C++ and Python API semantics.
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.