Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/restructure port map #177

Merged
merged 47 commits into from
Jan 2, 2024
Merged

Feature/restructure port map #177

merged 47 commits into from
Jan 2, 2024

Conversation

iitaku
Copy link
Collaborator

@iitaku iitaku commented Dec 19, 2023 •
edited
Loading

This PR includes:

  • Code restructure for port binding feature
  • Introduce Port::bind new API set which will deprecate PortMap (See test for usage)

@Fixstars-iizuka
WIP: Restructuing port mapping
aad7bfa
@Fixstars-iizuka
Fully moved into Halide::Internal::Parameter
dfd43ee
@Fixstars-iizuka
Enabled testcase for array output
878f344
@Fixstars-iizuka
Reverted
0fcc4c4
@Fixstars-iizuka
Fixed python tests
74ad6a5
@Fixstars-iizuka
WIP: Reorganizing array I/O
c84e16d
@Fixstars-iizuka
WIP: input array
d4afb8a
@Fixstars-iizuka
WIP: Fixing testcase
f702132
@Fixstars-iizuka
Avoid to use same variable name
90eab97
@Fixstars-iizuka
WIP: Pimplize Port class
083c9df
@Fixstars-iizuka
Fixed parameter name conflict
25cd76b
@Fixstars-iizuka
Fixed port deserializer to manage uniqueness of object
e5ef1ed
@Fixstars-iizuka
WIP: Holding parameter nicely
050b697
@Fixstars-iizuka
WIP: Map_at error
48643d3
@Fixstars-iizuka
Fixed python test
d9bc39f
@Fixstars-iizuka
Merge remote-tracking branch 'origin/master' into feature/restructure…
024d9c5 
…-port-map
@Fixstars-iizuka
Merge remote-tracking branch 'origin/feature/restructure-port-map' in…
95c13a6 
…to feature/restructure-port-map
@Fixstars-iizuka
WIP: Port can bind buffer or scalar value
39ca5dc
@Fixstars-iizuka
WIP
df33e8b
@Fixstars-iizuka
Passing proper argument stub and instance
87fc382
@Fixstars-iizuka
WIP: Work for both JIT and AOT
7477eab
@Fixstars-iizuka
Merge remote-tracking branch 'origin/master' into feature/restructure…
759f026 
…-port-map
@Fixstars-iizuka
Handle deserialied port properly
6fce047
@Fixstars-iizuka
Retrieve port properly
12ab96a
@Fixstars-iizuka
Fixed testcase to retrieve port from bb
00ee078
@Fixstars-iizuka
Removed old code
51224fa
@Fixstars-iizuka
WIP: Non-scalar parameter should be treated as non-embedded buffer
e73dc1e
@Fixstars-iizuka
WIP
d1b3f73
@Fixstars-iizuka
Reorganized buffer binding
c9b2c71
@Fixstars-iizuka
WIP: vparam
ec5bb36
@iitaku iitaku force-pushed the feature/restructure-port-map branch from a488d19 to ec5bb36 Compare December 28, 2023 02:11
@iitaku iitaku requested a review from xinyuli1204 January 2, 2024 18:16
@iitaku
Copy link
Collaborator Author

iitaku commented Jan 2, 2024

@xinyuli1204 Can you take over Python part?

  • Implement new Port::bind API sets
  • Fix python tutorial/sample code to use Port::bind

@iitaku
Copy link
Collaborator Author

iitaku commented Jan 2, 2024

@xinyuli1204 Can you take over Python part?

  • Implement new Port::bind API sets
  • Fix python tutorial/sample code to use Port::bind

I created #182 for the python part. I will merge this PR and let's keep working on the remaining on #182.

@iitaku iitaku merged commit 2c23367 into master Jan 2, 2024
@xinyuli1204
Copy link
Contributor

@xinyuli1204 Can you take over Python part?

  • Implement new Port::bind API sets
  • Fix python tutorial/sample code to use Port::bind

I created #182 for the python part. I will merge this PR and let's keep working on the remaining on #182.

OK , I will.

@iitaku iitaku deleted the feature/restructure-port-map branch January 21, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xinyuli1204 xinyuli1204 Awaiting requested review from xinyuli1204

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iitaku @xinyuli1204 @Fixstars-iizuka