Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/port access #164

Merged
merged 11 commits into from
Nov 30, 2023
Merged

Feature/port access #164

merged 11 commits into from
Nov 30, 2023

Conversation

xinyuli1204
Copy link
Contributor

@xinyuli1204 xinyuli1204 commented Nov 30, 2023 •
edited
Loading

  1. Allow intermediate building blocks to access the index of port if there are multiple outputs. eg:
    n = b.add("xxxxxxxx")(n["output"][1])
  2. Add test code "port-access"
  3. Add building blocks : Camera2 (output 2 ports, one image per port) and CameraN (output one port , n images per port)
  4. Fix "parse_url" to handle both https and http request.

iitaku
iitaku reviewed Nov 30, 2023
View reviewed changes
Copy link
Collaborator

@iitaku iitaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you unify coding style applying clang-format?

example/gender_count.cc Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the changes for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please review this again?

@iitaku
Copy link
Collaborator

iitaku commented Nov 30, 2023

@xinyuli1204 Style file is here. https://github.com/fixstars/ion-kit/blob/master/.clang-format

@xinyuli1204 xinyuli1204 reopened this Nov 30, 2023
@iitaku
Copy link
Collaborator

iitaku commented Nov 30, 2023

LGTM!

@iitaku iitaku merged commit 4436818 into fixstars:master Nov 30, 2023
2 checks passed
@Fixstars-momoko Fixstars-momoko mentioned this pull request Dec 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iitaku iitaku iitaku left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xinyuli1204 @iitaku