Skip to content

Commit

Permalink
Merge pull request #156 from Sensing-Dev/hotfix/buffer-is-null-issue-…
Browse files Browse the repository at this point in the history
…on-u3v

Hotfix/buffer is null issue on u3v
  • Loading branch information
iitaku authored Nov 13, 2023
2 parents 7d335d7 + bdf816d commit 1dd9131
Showing 1 changed file with 42 additions and 2 deletions.
44 changes: 42 additions & 2 deletions src/bb/image-io/rt_u3v.h
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,23 @@ class U3V {
uint64_t latest_cnt = 0;
int32_t min_frame_device_idx = 0;

//first buffer
cameN_idx_ = (cameN_idx_+1) >= num_device ? 0 : cameN_idx_+1;
bufs[cameN_idx_] = arv_stream_timeout_pop_buffer (devices_[cameN_idx_].stream_, 30 * 1000 * 1000);
if (bufs[cameN_idx_] == nullptr){
log::error("pop_buffer(L4) failed due to timeout ({}s)", timeout_us*1e-6f);
throw ::std::runtime_error("buffer is null");
}
devices_[cameN_idx_].frame_count_ = is_gendc_
? static_cast<uint64_t>(get_frame_count_from_genDC_descriptor(bufs[cameN_idx_], devices_[cameN_idx_]))
: static_cast<uint64_t>(arv_buffer_get_timestamp(bufs[cameN_idx_]) & 0x00000000FFFFFFFF);
latest_cnt = devices_[cameN_idx_].frame_count_;

int internal_count = 0;
int max_internal_count = 1000;

while (frame_cnt_ >= latest_cnt) {
arv_stream_push_buffer(devices_[cameN_idx_].stream_, bufs[cameN_idx_]);
cameN_idx_ = (cameN_idx_+1) >= num_device ? 0 : cameN_idx_+1;
bufs[cameN_idx_] = arv_stream_timeout_pop_buffer (devices_[cameN_idx_].stream_, 30 * 1000 * 1000);
if (bufs[cameN_idx_] == nullptr){
Expand All @@ -379,6 +395,10 @@ class U3V {
? static_cast<uint64_t>(get_frame_count_from_genDC_descriptor(bufs[cameN_idx_], devices_[cameN_idx_]))
: static_cast<uint64_t>(arv_buffer_get_timestamp(bufs[cameN_idx_]) & 0x00000000FFFFFFFF);
latest_cnt = devices_[cameN_idx_].frame_count_;
if (internal_count++ > max_internal_count){
log::error("pop_buffer(L9) The sequential invalid buffer is more than {}; Stop the pipeline.", max_internal_count);
throw ::std::runtime_error("Invalid framecount");
}
}

frame_cnt_ = latest_cnt;
Expand Down Expand Up @@ -482,18 +502,38 @@ class U3V {
uint64_t latest_cnt = 0;
int32_t min_frame_device_idx = 0;

while (frame_cnt_ >= latest_cnt){
//first buffer
cameN_idx_ = (cameN_idx_+1) >= num_device ? 0 : cameN_idx_+1;
bufs[cameN_idx_] = arv_stream_timeout_pop_buffer (devices_[cameN_idx_].stream_, 30 * 1000 * 1000);
if (bufs[cameN_idx_] == nullptr){
log::error("pop_buffer(L4) failed due to timeout ({}s)", timeout_us*1e-6f);
throw ::std::runtime_error("buffer is null");
}
devices_[cameN_idx_].frame_count_ = is_gendc_
? static_cast<uint64_t>(get_frame_count_from_genDC_descriptor(bufs[cameN_idx_], devices_[cameN_idx_]))
: static_cast<uint64_t>(arv_buffer_get_timestamp(bufs[cameN_idx_]) & 0x00000000FFFFFFFF);
latest_cnt = devices_[cameN_idx_].frame_count_;

int internal_count = 0;
int max_internal_count = 1000;

while (frame_cnt_ >= latest_cnt) {
arv_stream_push_buffer(devices_[cameN_idx_].stream_, bufs[cameN_idx_]);
cameN_idx_ = (cameN_idx_+1) >= num_device ? 0 : cameN_idx_+1;
auto timeout2_us = 30 * 1000 * 1000;
bufs[cameN_idx_] = arv_stream_timeout_pop_buffer (devices_[cameN_idx_].stream_, timeout2_us);
if (bufs[cameN_idx_] == nullptr){
log::error("pop_buffer(L8) failed due to timeout ({}s)", timeout2_us*1e-6f);
throw ::std::runtime_error("buffer is null");
}
}
devices_[cameN_idx_].frame_count_ = is_gendc_
? static_cast<uint64_t>(get_frame_count_from_genDC_descriptor(bufs[cameN_idx_], devices_[cameN_idx_]))
: static_cast<uint64_t>(arv_buffer_get_timestamp(bufs[cameN_idx_]) & 0x00000000FFFFFFFF);
latest_cnt = devices_[cameN_idx_].frame_count_;
if (internal_count++ > max_internal_count){
log::error("pop_buffer(L10) The sequential invalid buffer is more than {}; Stop the pipeline.", max_internal_count);
throw ::std::runtime_error("Invalid framecount");
}
}

frame_cnt_ = latest_cnt;
Expand Down

0 comments on commit 1dd9131

Please sign in to comment.