Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CArray and CIndexer Tests for Ultima #240

Merged
merged 4 commits into from
Sep 11, 2019

Conversation

vorj
Copy link

@vorj vorj commented Jul 29, 2019

One of the tasks of #185 .

This PR adds tests about CArray and CIndexer for Ultima.
This PR also contains a fix for ultima_tests/utility.py::exec_ultima the test cases.

@vorj vorj added the tests Create and/or modify tests label Jul 29, 2019
@vorj vorj requested a review from LWisteria July 29, 2019 09:07
Copy link

@jenkins-maekawa jenkins-maekawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test (commit 6820bfd) failed in titanv.

============================= test session starts ==============================
platform linux -- Python 3.6.5, pytest-4.3.0, py-1.8.0, pluggy-0.12.0
rootdir: /home/clpy-jenkins-slave/workspace/clpy_testing_titan, inifile: setup.cfg
collected 126 items / 1 errors / 125 selected

==================================== ERRORS ====================================
__ ERROR collecting tests/clpy_tests/opencl_tests/ultima_tests/test_carray.py __
import file mismatch:
imported module 'test_carray' has this __file__ attribute:
  /home/clpy-jenkins-slave/workspace/clpy_testing_titan/tests/clpy_tests/opencl_tests/test_carray.py
which is not the same as the test file we want to collect:
  /home/clpy-jenkins-slave/workspace/clpy_testing_titan/tests/clpy_tests/opencl_tests/ultima_tests/test_carray.py
HINT: remove __pycache__ / .pyc files and/or use a unique basename for your test file modules
!!!!!!!!!!!!!!!!!!! Interrupted: 1 errors during collection !!!!!!!!!!!!!!!!!!!!
=========================== 1 error in 1.07 seconds ============================

Copy link

@jenkins-maekawa jenkins-maekawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test (commit 6820bfd) failed in vega.

============================= test session starts ==============================
platform linux -- Python 3.6.5, pytest-4.3.0, py-1.8.0, pluggy-0.12.0
rootdir: /home/clpy-jenkins-slave/workspace/clpy_testing_vega, inifile: setup.cfg
collected 126 items / 1 errors / 125 selected

==================================== ERRORS ====================================
__ ERROR collecting tests/clpy_tests/opencl_tests/ultima_tests/test_carray.py __
import file mismatch:
imported module 'test_carray' has this __file__ attribute:
  /home/clpy-jenkins-slave/workspace/clpy_testing_vega/tests/clpy_tests/opencl_tests/test_carray.py
which is not the same as the test file we want to collect:
  /home/clpy-jenkins-slave/workspace/clpy_testing_vega/tests/clpy_tests/opencl_tests/ultima_tests/test_carray.py
HINT: remove __pycache__ / .pyc files and/or use a unique basename for your test file modules
!!!!!!!!!!!!!!!!!!! Interrupted: 1 errors during collection !!!!!!!!!!!!!!!!!!!!
=========================== 1 error in 0.56 seconds ============================

Copy link

@jenkins-maekawa jenkins-maekawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test (commit cc460ba) passed in titanv.

Copy link

@jenkins-maekawa jenkins-maekawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test (commit cc460ba) passed in vega.

@vorj
Copy link
Author

vorj commented Jul 29, 2019

@LWisteria please review this.

Copy link
Member

@LWisteria LWisteria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LWisteria LWisteria merged commit 016015a into clpy Sep 11, 2019
@LWisteria LWisteria deleted the 185-add-carray-cindexer-test-for-ultima branch September 11, 2019 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Create and/or modify tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants