Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test for ultima #185

Open
LWisteria opened this issue Feb 17, 2019 · 6 comments
Open

Test for ultima #185

LWisteria opened this issue Feb 17, 2019 · 6 comments
Assignees
@vorj
Labels
tests Create and/or modify tests

Comments

@LWisteria
Copy link
Member

There is no test for ultima itself. That absence could be problem.
@LWisteria LWisteria added the tests Create and/or modify tests label Feb 17, 2019
@LWisteria
Copy link
Member Author

@vorj I request you to try this issue.

@vorj vorj mentioned this issue Feb 28, 2019
Merged
@vorj
Copy link

vorj commented Feb 28, 2019 •
edited
Loading

@LWisteria I made the template of test case for ultima in #202.
Then, what should we check? Please let me know your opinion.

These are the test cases what I conceived:

  • General conversions
    • Type cast
      • Function style cast
      • C++ cast
    • Constructor
    • Template instantiation
    • Overload mangling
    • Tricking half
  • Specific Conversions
    • CArray<T, N> to __global T*, CArray_N
    • Operator overloading for CArray
    • Member functions for CArray and CIndexer
    • Header name mutation
    • Begin/end print out directives
    • Elementwise/reduction kernel conversion

@LWisteria
Copy link
Member Author

@vorj Firstly, do not send the big PR which contains whole cases. #202 (and a item you wrote above) is enough to merge. So please make those tests.

On the other hand, I will check the test cases, at latest before you finish the above cases.

@LWisteria
Copy link
Member Author

Anyway, this issue is not on the beta2 milestone thus #153 's priority is higher.

@vorj
Copy link

vorj commented Mar 14, 2019

OK, so I will create those test cases later.

@vorj vorj mentioned this issue Apr 16, 2019
Merged
@vorj vorj mentioned this issue Apr 26, 2019
Merged
@LWisteria
Copy link
Member Author

@vorj The file for ultima test will be large. How about making ultima_tests directory and dividing them into each file by test type?

@vorj vorj mentioned this issue May 15, 2019
Merged
This was referenced Jul 3, 2019
Merged
Merged
@vorj vorj mentioned this issue Jul 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vorj vorj

Labels
tests Create and/or modify tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LWisteria @vorj