Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple charsets and custom charset #2

Merged
merged 4 commits into from
Nov 14, 2023
Merged

Conversation

fityannugroho
Copy link
Owner

PR Checklist

Please check if your PR fulfills the following requirements:

Put [x] to check

  • I have read the documentation.
  • I have read and followed the Contributing Guidelines.
  • I have included a pull request description of my changes.
  • I have included the necessary changes to the documentation.
  • I have added tests to cover my changes.

PR Type

What kind of change does this PR introduce?

Please check any kind of changes that applies to this PR using [x]

  • Bug fix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • ..... (describe the other type)

What is the current behavior?

Please describe the current behavior that you are modifying, or link to a relevant issue.

Issue Number: N/A

Currently, wisely can only using one built-in charset.

What is the new behavior?

  • Add mergeCharSets() function to merge multiple charsets (both built-in and custom charset).
  • Rename wisely()'s options.charSet into options.charSets that receive an array and can contain both built-in and custom charset.
  • Validate built-in charset and custom charset with isCharSetValid().

Other information

None

@fityannugroho fityannugroho added the enhancement New feature or request label Nov 14, 2023
@fityannugroho fityannugroho merged commit 368035a into main Nov 14, 2023
2 checks passed
@fityannugroho fityannugroho deleted the feat/0.2.0 branch November 14, 2023 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant