Add functionality to print patch statistics in ASMStarPC and friends #3875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottMacLachlan
approved these changes
Nov 20, 2024
| V = get_function_space(dm) | ||
|
|
||
| # Obtain patches from user defined function | ||
| ises = self.get_patches(V) |
There was a problem hiding this comment.
It feels slightly extravagant to completely recompute the patch indices just for the sake of this monitor, but it is true that we don't stash these anywhere convenient for us to find. Is it worth stashing them in __init__ so that we don't need to recompute them here?
There was a problem hiding this comment.
I agree it's a bit wasteful. I agree we could stash them in __init__ if the option is present. I'll make this change.
|
|
|
This is a really useful option, thanks @pefarrell. Any chance you could add the mean patch size too? Could be useful to know if the min/max are particular outliers or not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We often would like to know what kind of sizes of patch problems we are dealing with in ASMStarPC and friends.
When using
-snes_view, PETSc prints out the size of the first patch on the first processor, but this isn't all that useful; really we want the minimum and maximum.This adds an option
-pc_star_print_patch_statisticsthat computes the minimum and maximum patch sizes and prints them out in the viewer, if requested.