Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flamenco: change hardcoded to use cluster version #2375

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

kbhargava-jump
Copy link
Contributor

@kbhargava-jump kbhargava-jump commented Jul 10, 2024

1180 refers to agave v1.18
2000 refers to agave v2.0

using --cluster-version 1180:

$ build/native/gcc/bin/fd_ledger --cmd replay --rocksdb dump/v20-harcoded-features/rocksdb --index-max 500000 --end-slot 700 --cluster-version 1180 --page-cnt 30 --funk-page-cnt 16 --snapshot dump/v20-harcoded-features/snapshot-100-4EmZxoqF6P2fJJEKgvznd2BkfTvYzsFSup3gyDdV2mY1.tar.zst --allocator wksp --tile-cpus 5-21

[Replay]
slot:             101
bank hash:        CrEjQ6m9XCmAj9oLN5fj7vURJht3Lk7S3JjKPyUTsZGK
parent bank hash: HWThLuko8gFDbc9fW2aBqQxVYJbhQJShXCDxSsA3YmVV
accounts_delta:   ER5k49x5hRKjCS31F6acAtf7WiBKPhiTmza28gf61CB6
signature_count:  1
last_blockhash:   CVpR9zJq5DC5M7FSB79DrJDd547XyZbafdNMsJTPo2AJ

WARNING 07-12 15:36:52.860106 2261126 5    0    src/app/ledger/main.c(253): Bank hash mismatch! slot=101 expected=8Rf42S3cDqEEMTzigf51g91UHuS2tEeCQGgpD9y5V6yj, got=CrEjQ6m9XCmAj9oLN5fj7vURJht3Lk7S3JjKPyUTsZGK

using --cluster-version 2000:

$ build/native/gcc/bin/fd_ledger --cmd replay --rocksdb dump/v20-harcoded-features/rocksdb --index-max 500000 --end-slot 700 --cluster-version 2000 --page-cnt 30 --funk-page-cnt 16 --snapshot dump/v20-harcoded-features/snapshot-100-4EmZxoqF6P2fJJEKgvznd2BkfTvYzsFSup3gyDdV2mY1.tar.zst --allocator wksp --tile-cpus 5-21

[Replay]
slot:             700
bank hash:        FHPWA2V2FtVopL8jJyZNxSKk86yQf6EFSFa7bneRxuRv
parent bank hash: 7hM3kDz9BM78wGrijNHqbV2aVN7SmxoHVZGmDKbgWaPq
accounts_delta:   ApZai6ykdZGcaaHK9HPLNFgHHyWiKVzRbddqjeXsLmWL
signature_count:  1
last_blockhash:   FE3o6GsYecQdk9Zvvz9MjsihirZrAPhbbU8nHbJwRYc6

NOTICE  07-12 15:36:59.831264 2261594 5    0    src/app/ledger/main.c(317): replay completed - slots: 600, elapsed: 0.776571 s, txns: 600, tps: 772.627175, sec/slot: 0.001294

@kbhargava-jump kbhargava-jump force-pushed the hardcoded-cluster-version branch 2 times, most recently from d3eb61a to 25e2637 Compare July 10, 2024 19:41
@kbhargava-jump kbhargava-jump force-pushed the hardcoded-cluster-version branch 4 times, most recently from ea2a40c to 29d06b2 Compare July 10, 2024 20:11
@jumpsiegel jumpsiegel self-requested a review July 10, 2024 20:19
@kbhargava-jump kbhargava-jump force-pushed the hardcoded-cluster-version branch 2 times, most recently from 63aa4ae to d3a392d Compare July 11, 2024 17:00
Copy link
Contributor

@topointon-jump topointon-jump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

src/flamenco/fd_flamenco_base.h Outdated Show resolved Hide resolved
@kbhargava-jump kbhargava-jump force-pushed the hardcoded-cluster-version branch from ccf230d to 23c1c30 Compare July 12, 2024 14:39
@kbhargava-jump kbhargava-jump marked this pull request as ready for review July 12, 2024 14:40
@kbhargava-jump kbhargava-jump force-pushed the hardcoded-cluster-version branch from 23c1c30 to af12aea Compare July 12, 2024 14:55
topointon-jump
topointon-jump previously approved these changes Jul 12, 2024
Copy link
Contributor

@topointon-jump topointon-jump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@kbhargava-jump kbhargava-jump enabled auto-merge July 12, 2024 15:42
@kbhargava-jump kbhargava-jump added this pull request to the merge queue Jul 12, 2024
@lheeger-jump lheeger-jump removed this pull request from the merge queue due to a manual request Jul 12, 2024
@lheeger-jump lheeger-jump added this pull request to the merge queue Jul 12, 2024
Merged via the queue into main with commit 2170356 Jul 12, 2024
11 checks passed
@lheeger-jump lheeger-jump deleted the hardcoded-cluster-version branch July 12, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants