-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flamenco: change hardcoded to use cluster version #2375
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbhargava-jump
force-pushed
the
hardcoded-cluster-version
branch
2 times, most recently
from
July 10, 2024 19:41
d3eb61a
to
25e2637
Compare
jumpsiegel
reviewed
Jul 10, 2024
jumpsiegel
reviewed
Jul 10, 2024
kbhargava-jump
force-pushed
the
hardcoded-cluster-version
branch
4 times, most recently
from
July 10, 2024 20:11
ea2a40c
to
29d06b2
Compare
kbhargava-jump
force-pushed
the
hardcoded-cluster-version
branch
2 times, most recently
from
July 11, 2024 17:00
63aa4ae
to
d3a392d
Compare
kbhargava-jump
commented
Jul 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
kbhargava-jump
force-pushed
the
hardcoded-cluster-version
branch
from
July 12, 2024 14:39
ccf230d
to
23c1c30
Compare
kbhargava-jump
force-pushed
the
hardcoded-cluster-version
branch
from
July 12, 2024 14:55
23c1c30
to
af12aea
Compare
topointon-jump
previously approved these changes
Jul 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
kbhargava-jump
force-pushed
the
hardcoded-cluster-version
branch
from
July 12, 2024 15:36
af12aea
to
dbf34cb
Compare
topointon-jump
approved these changes
Jul 12, 2024
jumpsiegel
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1180 refers to agave v1.18
2000 refers to agave v2.0
using
--cluster-version 1180
:using
--cluster-version 2000
: