Skip to content

Commit

Permalink
address PR comments
Browse files Browse the repository at this point in the history
  • Loading branch information
ravyu-jump committed May 15, 2024
1 parent 2e6a5d8 commit 2fbf62d
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/ballet/sbpf/fd_sbpf_loader.h
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ fd_sbpf_program_new( void * prog_mem,
https://github.com/solana-labs/rbpf/blob/v0.3.0/src/vm.rs#L198
Solana/Agave equivalent:
https://github.com/solana-labs/rbpf/blob/main/src/elf.rs#L361
https://github.com/solana-labs/rbpf/blob/v0.8.0/src/elf.rs#L361
*/

int
Expand Down
7 changes: 7 additions & 0 deletions src/flamenco/runtime/tests/fd_exec_instr_test.h
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,13 @@ fd_exec_instr_test_run( fd_exec_instr_test_runner_t * runner,
void * output_buf,
ulong output_bufsz );

/* Loads an ELF binary (in input->elf.data()).
output_buf points to a memory region of output_bufsz bytes where the
result is allocated into. Upon a successful load, the contents of
fd_sbpf_program_t are wrapped in *output (backed by output_buf)
and returns number of bytes allocated at output_buf.
Any failure to load the ELF binary results in a 0UL return value.
*/
ulong
fd_sbpf_program_load_test_run( fd_exec_test_elf_loader_ctx_t const * input,
fd_exec_test_elf_loader_effects_t ** output,
Expand Down
1 change: 1 addition & 0 deletions src/flamenco/runtime/tests/fd_exec_test.proto
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,7 @@ message ELFLoaderCtx {
}

// Captures the results of a elf binary load.
// Structurally similar to fd_sbpf_program_t
message ELFLoaderEffects {
// loaded program rodata
bytes rodata = 1
Expand Down

0 comments on commit 2fbf62d

Please sign in to comment.