Some tweaks to the jira app #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 3, 2014 12:08
… instead of bin/config.ini
… on urls with uri paths. eg: https://jira.example.com/jira Moved the config.ini.sample from bin to default. Added the key pathname to config.ini.sample Adjusted jira_rest.py jira_soap.py and jira_xml.py to take uri pathname into account.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Fred,
Hope all is well, I made few changes to this app to bring it more inline with app creation best practices.
The config.ini is now referenced under /local/config.ini instead of bin. This prevents config.ini deletion in the case of an app upgrade. I moved the sample file config.ini.sample to the default folder and changed the readme as well.
With regards to code changes, I found the was no way of specifying uri pathname. So I incorporated the key pathname to the config.ini and added some conditional states under the jira_rest.py, jirasoap.py, jiraxml.py to handle the case when jira endpoints are formated:
https://jira.example.com:443/jira
Pretty useful app :)
Cheers,
Neil