Change how FDC determines whether creating a CSQL free trial is allowed. #8065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredzqm
approved these changes
Dec 23, 2024
There was a problem hiding this comment.
Thanks @rosalyntan for the change!
This makes sense. So firebase init will continue to use the metric to determine whether or not to show the free trial option, but firebase deploy will try it first.
joehan
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the CLI determines whether it can create a CSQL free trial instance by querying for the presence of the free trial metric. However, some projects (mostly internal testing projects) have been allowlisted to have unlimited free trial instances, and creating a CSQL instance via the CLI fails for these projects if they previously had a free trial instance.
This PR updates the provisioning logic use the backend error for determining whether a free trial instance can be created, instead of just the presence of the free trial metric.
Scenarios Tested
firebase deployfor a non-allowlisted project that previously had a free trial instancefirebase deployfor an allowlisted project that previously had a free trial instanceSample Commands