Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for v2 callable functions #229

Merged
merged 7 commits into from
May 30, 2024

Conversation

exaby73
Copy link
Contributor

@exaby73 exaby73 commented Apr 10, 2024

Description

Closes #163

Code sample

// src/index.ts
import { onCall } from "firebase-functions/v2/https";

export const helloWorld = onCall(request => {
  return { message: "hello" };
});
// test/index.test.ts
import { helloWorld } from "../src/index";

describe("test", () => {
  it('should work', () => {
    const wf = wrap(helloWorld);
    wf(req, res);
  })
})

@exaby73 exaby73 marked this pull request as ready for review May 15, 2024 09:23
@aIacoella
Copy link

How's it possibile this is not fixed yet...

@blidd-google blidd-google self-requested a review May 20, 2024 16:18
@exaby73 exaby73 force-pushed the feat/on-call-support branch from f6620b6 to 54c6b48 Compare May 21, 2024 13:16
@blidd-google blidd-google merged commit 3f85954 into master May 30, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect "wrap" typing for v2 onCall cloud functions
3 participants