Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update benchmark app #6527

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Update benchmark app #6527

merged 2 commits into from
Nov 20, 2024

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Nov 20, 2024

The old version stop working due to a combination of gradle version and outdated deps

The old version stop working due to a combination of gradle version
and outdated deps
Copy link
Contributor

github-actions bot commented Nov 20, 2024

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v5.2

Copy link
Contributor

Test Results

 1 036 files  +  926   1 036 suites  +926   36m 47s ⏱️ + 34m 33s
 5 873 tests +4 905   5 851 ✅ +4 883  22 💤 +22  0 ❌ ±0 
11 831 runs  +9 887  11 787 ✅ +9 843  44 💤 +44  0 ❌ ±0 

Results for commit b063ea6. ± Comparison against base commit 1f9e582.

@google-oss-bot
Copy link
Contributor

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 45.71% (1f9e582) to 45.73% (3a2ab87) by +0.01%.

    FilenameBase (1f9e582)Merge (3a2ab87)Diff
    LruGarbageCollector.java93.64%97.27%+3.64%
  • firebase-messaging

    Overall coverage changed from 84.19% (1f9e582) to 84.08% (3a2ab87) by -0.11%.

    FilenameBase (1f9e582)Merge (3a2ab87)Diff
    Metadata.java41.27%36.51%-4.76%
  • firebase-ml-modeldownloader

    Overall coverage changed from 83.38% (1f9e582) to 83.32% (3a2ab87) by -0.06%.

    FilenameBase (1f9e582)Merge (3a2ab87)Diff
    FirebaseModelDownloader.java84.66%84.05%-0.61%
  • firebase-storage

    Overall coverage changed from ? (1f9e582) to 84.12% (3a2ab87) by ?.

    48 individual files with coverage change

    FilenameBase (1f9e582)Merge (3a2ab87)Diff
    ActivityLifecycleListener.java?74.14%?
    AdaptiveStreamBuffer.java?84.62%?
    CancelException.java?100.00%?
    CancellableTask.java?100.00%?
    ControllableTask.java?100.00%?
    DeleteNetworkRequest.java?100.00%?
    DeleteStorageTask.java?100.00%?
    ExponentialBackoffSender.java?86.00%?
    FileDownloadTask.java?80.00%?
    FirebaseStorage.java?83.67%?
    FirebaseStorageComponent.java?100.00%?
    GetDownloadUrlTask.java?96.77%?
    GetMetadataNetworkRequest.java?100.00%?
    GetMetadataTask.java?85.19%?
    GetNetworkRequest.java?100.00%?
    HttpURLConnectionFactory.java?0.00%?
    HttpURLConnectionFactoryImpl.java?50.00%?
    ListNetworkRequest.java?100.00%?
    ListResult.java?100.00%?
    ListTask.java?85.71%?
    NetworkRequest.java?87.85%?
    OnPausedListener.java?0.00%?
    OnProgressListener.java?0.00%?
    ResumableNetworkRequest.java?100.00%?
    ResumableUploadByteRequest.java?90.91%?
    ResumableUploadCancelRequest.java?100.00%?
    ResumableUploadQueryRequest.java?100.00%?
    ResumableUploadStartRequest.java?95.24%?
    Slashes.java?88.24%?
    Sleeper.java?0.00%?
    SleeperImpl.java?100.00%?
    SmartHandler.java?92.31%?
    Storage.kt?39.58%?
    StorageException.java?69.09%?
    StorageMetadata.java?86.34%?
    StorageReference.java?89.94%?
    StorageReferenceUri.java?100.00%?
    StorageRegistrar.java?100.00%?
    StorageTask.java?83.69%?
    StorageTaskManager.java?100.00%?
    StorageTaskScheduler.java?95.45%?
    StreamDownloadTask.java?88.89%?
    TaskListenerImpl.java?100.00%?
    TaskState.kt?0.00%?
    UpdateMetadataNetworkRequest.java?100.00%?
    UpdateMetadataTask.java?82.14%?
    UploadTask.java?81.52%?
    Util.java?73.24%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/tJNGNfLXPX.html

@rlazo rlazo enabled auto-merge (squash) November 20, 2024 21:43
Copy link
Member

@daymxn daymxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but double check that the smoke tests failures

@rlazo rlazo merged commit 6a03d4c into main Nov 20, 2024
263 of 265 checks passed
@rlazo rlazo deleted the rl.macrobenchmark.fix.2 branch November 20, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants