Make the session id not depend on fetching the fid #6152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release note changesThe following release notes were modified. Please ensure they look correct. Release Notesfirebase-crashlytics### {{crashlytics}} version 19.0.4 {: #crashlytics_v19-0-4}
* {{feature}} Added the `isCrashlyticsCollectionEnabled` API to check if Crashlytics collection is enabled.
([Github #5919](//github.com/firebase/firebase-android-sdk/issues/5919))
* {{fixed}} Ensure that on-demand fatal events are never processed on the main thread.
* {{changed}} Internal changes to the way session IDs are generated.
#### {{crashlytics}} Kotlin extensions version 19.0.4 {: #crashlytics-ktx_v19-0-4}
The Kotlin extensions library transitively includes the updated
`firebase-crashlytics` library. The Kotlin extensions library has no additional
updates. |
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
Coverage Report 1Affected ProductsTest Logs |
Size Report 1Affected Products
Test Logs |
Startup Time Report 1Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS. Notes
Startup Times
|
mrober
force-pushed
the
crashlytics-sessionId
branch
from
4880e1b
to
57aaf39
Compare
themiswang
approved these changes
Aug 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make generating a session id not depend on fetching the fid. This is needed so we can allow the common worker to initialize, and start accepting use actions, before any data collection, settings, or fid validation happens.
The hash of the crashlytics installation id was used to pad the length and increase entropy. Instead of that, we use a random uuid now. Verified nothing depends on the source of that padding by manually setting it to all 0s and doing an end-to-end test.
The way the session id is built is a little bit weird, using bytes. In the future, we could rewrite this to use proper string formatting.