Serialize the data as found on entities rather than read it into protocol classes #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelbey
force-pushed
the
raw_entity
branch
from
900483d to
446ec73
Compare
rafaelbey
force-pushed
the
raw_entity
branch
from
105767b to
4de7368
Compare
kevin-m-knight-gs
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to avoid converting entities into the most recent protocol classes. This will ensure the PMCD is produced with the content as when the project was published.
The metadata clients will then be responsible of converting older protocols to newer ones, something that will depend on the version of Engine they are using for deserialization.
This should also reduce CPU usage as metadata wont need to convert entities into protocol to convert back to json.