Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facelift: Alerts #120

Merged
merged 14 commits into from
Feb 23, 2024
Merged

Facelift: Alerts #120

merged 14 commits into from
Feb 23, 2024

Conversation

JuroUhlar
Copy link
Collaborator

@JuroUhlar JuroUhlar commented Feb 11, 2024

Nicer alerts.

  • Kept notistack but created a custom CustomSnackbar component for greater control over styles.
  • Shared some styles between static on-page alerts and dynamic over-the-page snackbars.
  • Cross icon used as SVG component because it needs to inherit color from the parent's CSS styles.
  • Refactored reset endpoint to use the new validation pattern and to return a structured response that is easier to display in a custom way, instead of just a single message string.

Design: https://www.figma.com/file/Rw0BBJ46Fpbx5s5lWflhVy/Fingerprint-Hub-Demo-Project?node-id=1515%3A37773&mode=dev (I haven't implemented totally everything, just 80:20, will come back when higher priorities are finished)

Demo: https://staging.fingerprinthub.com/personalization

@JuroUhlar JuroUhlar marked this pull request as ready for review February 21, 2024 20:12
@JuroUhlar JuroUhlar merged commit 4110862 into main Feb 23, 2024
5 checks passed
@JuroUhlar JuroUhlar deleted the facelift/modals-and-alerts branch February 23, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants