Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Make cards clickable using links and CSS INTER-263 #119

Merged
merged 3 commits into from
Jan 31, 2024
Merged

chore: Make cards clickable using links and CSS INTER-263 #119

merged 3 commits into from
Jan 31, 2024

Conversation

JuroUhlar
Copy link
Collaborator

@JuroUhlar JuroUhlar commented Jan 30, 2024 •
edited
Loading

We need to make the whole homepage cards clickable.

  • But wrapping the whole card in an <a> element is bad for screen readers/accessibility.
  • And using an onClick event on the card confuses Google Tag Manager triggers, it registers click instead of linkClick events.
  • So this is some CSS magic to make the whole card clickable using the child <a> element

@JuroUhlar JuroUhlar marked this pull request as ready for review January 31, 2024 10:24
ilfa
ilfa previously approved these changes Jan 31, 2024
View reviewed changes
@JuroUhlar JuroUhlar merged commit b0c8c0a into main Jan 31, 2024
5 checks passed
@JuroUhlar JuroUhlar deleted the chore/fix-gtm-triggers-inter-263 branch January 31, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilfa ilfa ilfa approved these changes

@TheUnderScorer TheUnderScorer Awaiting requested review from TheUnderScorer TheUnderScorer is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JuroUhlar @ilfa