chore: remove waiting for network idle

fingerprintjs · Feb 29, 2024 · 6886ac9 · 6886ac9
1 parent 72b1e50
commit 6886ac9
Show file tree

Hide file tree

Showing 6 changed files with 5 additions and 8 deletions.
diff --git a/.github/workflows/production_e2e.yml b/.github/workflows/production_e2e.yml
@@ -3,6 +3,8 @@ on:
   schedule:
     - cron: '0 * * * *' # Run every hour
   workflow_dispatch:
+  pull_request:
+    branches: [main]
 env:
   # Playwright headless browsers running in CI get low confidence scores, causing flaky e2e tests. Lower the confidence score threshold for CI testing.
   MIN_CONFIDENCE_SCORE: 0

diff --git a/e2e/personalization.spec.ts b/e2e/personalization.spec.ts
@@ -7,9 +7,7 @@ const PERS_ID = TEST_IDS.personalization;
 
 test.describe('Personalization', () => {
   test.beforeEach(async ({ page }) => {
-    await page.goto('/personalization', {
-      waitUntil: 'networkidle',
-    });
+    await page.goto('/personalization');
     await page.getByText('Okay, I understand').click();
     await resetScenarios(page);
   });

diff --git a/e2e/playground.spec.ts b/e2e/playground.spec.ts
@@ -18,7 +18,6 @@ const getServerResponse = async (page: Page) => {
 
 const clickPlaygroundRefreshButton = async (page: Page) => {
   await page.getByTestId(PLAYGROUND_TAG.refreshButton).first().click();
-  await page.waitForLoadState('networkidle');
   // Artificial wait necessary to make sure you get the updated response every time
   await page.waitForTimeout(3000);
 };
@@ -103,6 +102,5 @@ test.describe('Proxy integration', () => {
 
     await page.goto('/playground');
     await clickPlaygroundRefreshButton(page);
-    await page.waitForLoadState('networkidle');
   });
 });
diff --git a/e2e/resetHelper.ts b/e2e/resetHelper.ts
@@ -4,6 +4,5 @@ import { TEST_IDS } from '../src/client/testIDs';
 // Assumes you already are on a use case page with the Reset button present
 export async function resetScenarios(page: Page) {
   await page.getByTestId(TEST_IDS.reset.resetButton).click();
-  await page.waitForLoadState('networkidle');
   await page.getByTestId(TEST_IDS.reset.resetSuccess).waitFor({ timeout: 10000 });
 }
diff --git a/e2e/scraping/protected.spec.ts b/e2e/scraping/protected.spec.ts
@@ -3,7 +3,7 @@ import { TEST_IDS } from '../../src/client/testIDs';
 
 test.describe('Scraping flights', () => {
   test('is not possible with Bot detection on', async ({ page }) => {
-    await page.goto('/web-scraping', { waitUntil: 'networkidle' });
+    await page.goto('/web-scraping');
     await expect(page.getByTestId(TEST_IDS.common.alert)).toContainText('Malicious bot detected', {
       timeout: 10000,
     });

diff --git a/e2e/scraping/unprotected.spec.ts b/e2e/scraping/unprotected.spec.ts
@@ -11,7 +11,7 @@ const scrapeText = async (parent: Locator, testId: string) => {
 
 test.describe('Scraping flights', () => {
   test('is possible with Bot detection off', async ({ page }) => {
-    await page.goto('/web-scraping?disableBotDetection=1', { waitUntil: 'networkidle' });
+    await page.goto('/web-scraping?disableBotDetection=1');
     // Artificial wait necessary to prevent flakiness
     await page.waitForTimeout(3000);