Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update ios and android agents to v2.7.0 INTER-1002 #135

Open
wants to merge 42 commits into
base: main
Choose a base branch
from

Conversation

Orkuncakilkaya
Copy link

@Orkuncakilkaya Orkuncakilkaya commented Nov 19, 2024

This PR solves INTER-1002

RNFingerprintjsPro.podspec Outdated Show resolved Hide resolved
@Orkuncakilkaya Orkuncakilkaya marked this pull request as ready for review December 3, 2024 09:11
@Orkuncakilkaya Orkuncakilkaya marked this pull request as draft December 3, 2024 10:56
@necipallef necipallef changed the title feat: update ios and android agents to v2.7.0 feat: update ios and android agents to v2.7.0 INTER-1002 Dec 6, 2024
Copy link

github-actions bot commented Dec 12, 2024

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements
47.14% (+4.74% 🔼)
66/140
🔴 Branches
38.78% (+14.45% 🔼)
19/49
🔴 Functions
43.9% (+1.4% 🔼)
18/41
🔴 Lines
45.59% (+5.09% 🔼)
62/136
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴 errors.ts
15.38% (-0.62% 🔻)
10.71% (-0.4% 🔻)
15.38% (-0.62% 🔻)
15.38% (-0.62% 🔻)

Test suite run success

21 tests passing in 3 suites.

Report generated by 🧪jest coverage report action from 7cb2d69

Show full coverage report
St File % Stmts % Branch % Funcs % Lines Uncovered Line #s
🔴 All files 47.14 38.77 43.9 45.58
🟡  FingerprintJsProAgent.ts 76.92 76.47 100 76.92 39,59-62,95,103
🟡  FingerprintJsProContext.ts 75 100 0 75 5
🟢  FingerprintJsProProvider.tsx 93.33 50 100 93.33 44
🔴  errors.ts 15.38 10.71 15.38 15.38 8-33,56-249,272-285,332-336,343-379,383
🔴  index.ts 0 0 0 0
🔴  types.ts 0 0 0 0
🟢  useVisitorData.ts 100 100 100 100

src/FingerprintJsProAgent.ts Outdated Show resolved Hide resolved
Copy link
Member

@ilfa ilfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the markup to improve the UX of the demo project on the small screens. Also, I added 2 tests to be sure about timeout behavior.

In general I found only one problem - an outdated lock file for TestProject.

@@ -23,14 +23,14 @@
"@react-native/metro-config": "0.73.3",
"babel-jest": "^29.6.3",
"eslint": "^8.19.0",
"jest": "^27.4.7",
"jest": "^29.4.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to commit updated lock file

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks!

@necipallef necipallef marked this pull request as ready for review December 24, 2024 08:59
Copy link

This PR will create a minor release 🚀

3.3.0 (2024-12-24)

Features

  • add custom timeout feature (4f7cca6)
  • add sealed result support to sdk (da1451b)
  • add sealed result support to sdk (de48e5e)
  • android bridge refactor, add methods for timeout (dd917e4)
  • ios bridge refactor, added new methods with timeout (5015345)
  • js side timeout param handling (fcef4f7)
  • update ios and android agents to v2.7.0 (9a34f87)

Bug Fixes

  • android bridge type error (5ac2ec4)
  • android timeout native bridge code (5440ee4)
  • attempt to fix android type problem (d85c266)
  • client timeout error (d19d747)
  • correct native function call when timeout is 0 (8786062)
  • ios timeout feature native bridge (6693757)
  • missing requestOptions in provider (a02128d)
  • node22 assert keyword, fix sourcemaps (a24f93a)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants