Fingerprint V6: update stable fingerprint #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alexey-Verkhovsky
approved these changes
Dec 9, 2024
Based on the report #115 and also on our internal data, BatteryFullCapacitySignal could fluctuate occasionally on some devices. Although this signal provided some additional uniqueness to the stable fingerprint, the decision was made to move it to the "Optimal" stability tier to prioritise stability. Implementation note: current code organization does not allow to make such changes easily, so I had to duplicate the original signal and assign it another stability level.
Sergey-Makarov
force-pushed
the
feature/fingerprint-v6-improve-stable-fingerprint
branch
from
8758fa3 to
feb5011
Compare
Sergey-Makarov
deleted the
feature/fingerprint-v6-improve-stable-fingerprint
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the report
#115 and also on our internal data, BatteryFullCapacitySignal could fluctuate occasionally on some devices. Although this signal provided some additional uniqueness to the stable fingerprint, the decision was made to move it to the "Optimal" stability tier to prioritise stability.
Implementation note: current code organization does not allow to make such changes easily, so I had to duplicate the original signal and assign it another stability level.