Skip to content

Commit

Permalink
Bring back targetSdk into the build.gradle of the library. It's used …
Browse files Browse the repository at this point in the history 
…only for tests and lint and does not affect the library's manifest.
  • Loading branch information
@Sergey-Makarov
Sergey-Makarov committed Sep 28, 2023
1 parent e267d55 commit 5551948
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions fingerprint/build.gradle.kts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,13 @@ android {
compileSdk = 34

Check warning

Code scanning / detekt

Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning

This expression contains a magic number. Consider defining it to a well named constant.

defaultConfig {
// This property does not affect the library itself, but affects test apk and lint.
// As for now, I don't see any non-deprecated ways of accomplishing this task.
// Discussions:
// https://stackoverflow.com/questions/76084080/apply-targetsdk-in-android-instrumentation-test
// https://issuetracker.google.com/issues/230625468 (looks like lint.targetSdk and testOptions.targetSdk will become available soon)

Check warning

Code scanning / detekt

Line detected that is longer than the defined maximum line length in the code style. Warning

Line detected that is longer than the defined maximum line length in the code style.
targetSdk = 33

minSdk = 21

Check warning

Code scanning / detekt

Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning

This expression contains a magic number. Consider defining it to a well named constant.
testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"
consumerProguardFiles("consumer-rules.pro")
Expand Down

0 comments on commit 5551948

Please sign in to comment.