Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use datacenter field for the IpInfo signal instead of the wrong dataCenter, deprecate IPLocation #45

Merged
merged 3 commits into from
Jan 12, 2024

Conversation

ilfa
Copy link
Member

@ilfa ilfa commented Jan 3, 2024

No description provided.

Copy link
Contributor

github-actions bot commented Jan 3, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
5858 3329 57% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
fingerprint_pro_server_api_sdk/models/botd_detection_result.py 52% 🟢
fingerprint_pro_server_api_sdk/models/botd_result.py 62% 🟢
fingerprint_pro_server_api_sdk/models/event_response.py 51% 🟢
fingerprint_pro_server_api_sdk/models/ip_info_result.py 52% 🟢
fingerprint_pro_server_api_sdk/models/ip_info_result_v4.py 64% 🟢
fingerprint_pro_server_api_sdk/models/ip_info_result_v6.py 40% 🟢
fingerprint_pro_server_api_sdk/models/ip_location.py 74% 🟢
fingerprint_pro_server_api_sdk/models/products_response.py 81% 🟢
fingerprint_pro_server_api_sdk/models/raw_device_attributes_result.py 36% 🟢
fingerprint_pro_server_api_sdk/models/response.py 65% 🟢
TOTAL 58% 🟢

updated for commit: 53bcda2 by action🐍

This comment has been minimized.

docs/IpInfoResultV4.md Outdated Show resolved Hide resolved
@JuroUhlar
Copy link
Contributor

@ilfa Tested locally and can confirm that the data center info is now available in datacenter with data_center being None, same as before. I left one suggestion regarding the generated docs, not sure if feasible. If not, consider the PR approved. :)

image

JuroUhlar

This comment was marked as duplicate.

@ilfa ilfa force-pushed the INTER-481-fixed-datacenter-name branch from f0ca301 to 53bcda2 Compare January 10, 2024 12:37
Copy link
Contributor

This PR will create a major release 🚀

3.0.0 (2024-01-10)

⚠ BREAKING CHANGES

  • IpInfo field data_center renamed to datacenter

Features

  • deprecate IPLocation (b39189b)
  • use datacenter field instead of the wrong dataCenter (53bcda2)

@ilfa ilfa changed the title Introduce datacenter field for the IpInfo signal in addition to the wrong dataCenter, deprecate IPLocation Use datacenter field for the IpInfo signal instead of the wrong dataCenter, deprecate IPLocation Jan 10, 2024
Copy link
Contributor

@JuroUhlar JuroUhlar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, works as expected

@ilfa ilfa merged commit f153d44 into main Jan 12, 2024
8 checks passed
@ilfa ilfa deleted the INTER-481-fixed-datacenter-name branch January 12, 2024 11:08
@ilfa
Copy link
Member Author

ilfa commented Jan 12, 2024

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ilfa ilfa added the released label Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants