Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use datacenter field for the IpInfo signal instead of the wrong dataCenter, deprecate IPLocation #82

Merged
merged 4 commits into from
Jan 11, 2024

Conversation

ilfa
Copy link
Member

@ilfa ilfa commented Jan 2, 2024

No description provided.

@ilfa ilfa requested a review from Orkuncakilkaya as a code owner January 2, 2024 18:42

This comment has been minimized.

Orkuncakilkaya
Orkuncakilkaya previously approved these changes Jan 3, 2024
JuroUhlar
JuroUhlar previously approved these changes Jan 4, 2024
Copy link
Contributor

@JuroUhlar JuroUhlar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work as expected, looks good to me!
image

@ilfa ilfa dismissed stale reviews from JuroUhlar and Orkuncakilkaya via 03cbb6f January 10, 2024 12:27
@ilfa ilfa force-pushed the INTER-481-fixed-datacenter-name branch from e507b94 to 03cbb6f Compare January 10, 2024 12:27
@ilfa ilfa changed the title Introduce datacenter field for the IpInfo signal in addition to the wrong dataCenter, deprecate IPLocation Use datacenter field for the IpInfo signal instead of the wrong dataCenter, deprecate IPLocation Jan 10, 2024
BREAKING CHANGE: `IpInfo` field `data_center` renamed to `datacenter`
@ilfa ilfa force-pushed the INTER-481-fixed-datacenter-name branch from 03cbb6f to 19158aa Compare January 10, 2024 12:29
Copy link
Contributor

This PR will create a major release 🚀

3.0.0 (2024-01-10)

⚠ BREAKING CHANGES

  • IpInfo field data_center renamed to datacenter

Features

  • deprecate IPLocation (ad6201c)
  • use datacenter instead of the wrong dataCenter (19158aa)

@ilfa ilfa merged commit ce76979 into main Jan 11, 2024
12 checks passed
@ilfa ilfa deleted the INTER-481-fixed-datacenter-name branch January 11, 2024 15:46
@ilfa
Copy link
Member Author

ilfa commented Jan 11, 2024

🎉 This PR is included in version 3.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@ilfa ilfa added the released label Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants