Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add webhook sign validating feature inter-768 #101

Merged
merged 3 commits into from
Aug 12, 2024
Merged

Add webhook sign validating feature inter-768 #101

merged 3 commits into from
Aug 12, 2024

Conversation

Orkuncakilkaya
Copy link
Contributor

No description provided.

TheUnderScorer
TheUnderScorer reviewed Aug 8, 2024
View reviewed changes
Copy link
Contributor

@TheUnderScorer TheUnderScorer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT, I have just one small suggestion :)

src/Webhook/WebhookVerifier.php Outdated Show resolved Hide resolved
ilfa
ilfa reviewed Aug 9, 2024
View reviewed changes
docs/Webhook.md Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 9, 2024

This PR will create a major release 🚀

5.0.0 (2024-08-09)

⚠ BREAKING CHANGES

  • API Methods now throws SerializationException
  • API Methods returns tuple instead of models
  • API Methods removed other than getModel
  • Upgraded minimum php version to 8.1
  • Request logic is rewritten, Upgraded minimum php version to 8.1

Features

  • add support for validating webhook signatures inter-768 (6a4cbd6)
  • change api to return tuple instead of serialized model (62e4ad3)
  • introduce rawResponse for getVisits and getEvent methods (9b01ba6)
  • introduce serialization exception (bfea23a)
  • only generate models and docs from swagger codegen (26e984f)
  • remove raw response and introduce with http info (ce2fedf)
  • rewrite request logic (0016822)
  • upgrade min php version to 8 (5698871)

@Orkuncakilkaya Orkuncakilkaya merged commit 698f0a0 into develop Aug 12, 2024
9 checks passed
@Orkuncakilkaya Orkuncakilkaya deleted the feature/add-webhook-signing-feature branch August 12, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheUnderScorer TheUnderScorer TheUnderScorer approved these changes

@ilfa ilfa ilfa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Orkuncakilkaya @ilfa @TheUnderScorer