chore(coverage): coverage inside phpunit xml file

fingerprintjs · Sep 3, 2024 · 3d81684 · 3d81684
1 parent 6fcaae0
commit 3d81684
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 10 deletions.
diff --git a/.github/workflows/coverage-diff.yml b/.github/workflows/coverage-diff.yml
@@ -26,7 +26,7 @@ jobs:
       - name: Clear previous coverage data
         run: rm -f cov/xml/clover-pr.xml cov/xml/clover-base.xml cov/xml/clover.xml
       - name: PHPUnit for PR
-        run: docker-compose run phpunit --coverage-clover=cov/xml/clover.xml
+        run: docker-compose run phpunit
       - name: Create coverage report for PR
         id: pr_coverage
         run: |
@@ -58,7 +58,7 @@ jobs:
       - name: "Create Empty env File for Docker"
         run: touch .env
       - name: PHPUnit for Base
-        run: docker-compose run phpunit --coverage-clover=cov/xml/clover.xml
+        run: docker-compose run phpunit
       - name: Create coverage report for Base
         id: base_coverage
         run: |

diff --git a/.github/workflows/coverage-report.yml b/.github/workflows/coverage-report.yml
@@ -25,7 +25,7 @@ jobs:
       - name: "Create Empty env File for Docker"
         run: touch .env
       - name: PHPUnit
-        run: docker-compose run phpunit --coverage-xml cov/xml --coverage-html cov/html --coverage-clover=cov/xml/clover.xml
+        run: docker-compose run phpunit
       - name: "Parse Coverage"
         run: "php ./coverage.php"
       - name: Create Coverage Badges

diff --git a/contributing.md b/contributing.md
@@ -21,27 +21,27 @@ To download fresh OpenAPI schema run `sh ./scripts/sync.sh`
 
 To generate a code coverage report in markdown format, follow these steps:
 
-1. Run PHPUnit with the `--coverage-clover` option to generate a coverage report in Clover XML format:
+1. Run PHPUnit to generate a coverage report in Clover XML format:
    ```shell
-   docker-compose run phpunit --coverage-clover=cov/xml/clover.xml
+   docker-compose run phpunit
    ```
-2. After generating the Clover XML file, run the coverage.php script to convert it into a markdown report:
+2. After PHPUnit generates the Clover XML file in `cov/xml/clover.xml`, run the coverage.php script to convert it into a markdown report:
     ```shell
    docker-compose run php php coverage.php
     ```
 
-The markdown report will be saved in the cov/markdown/coverage_report.md file. You can open this file to review the coverage details.
+The markdown report will be saved in the `cov/markdown/coverage_report.md` file. You can open this file to review the coverage details.
 
 ## Creating Coverage Report (HTML)
 
 To generate a code coverage report in HTML format, just run this command:
 
-Run PHPUnit with the `--coverage-html` option to generate a coverage report in Clover HTML format:
+Run PHPUnit to generate a coverage report in HTML format:
 ```shell
-docker-compose run phpunit --coverage-html=cov/html
+docker-compose run phpunit
 ```
 
-The html report will be saved in the cov/html directory. You can open this folder to review the coverage details.
+The html report will be saved in the `cov/html` directory. You can open this folder to review the coverage details.
 
 ### Testing the local source code of the SDK
 

diff --git a/phpunit.xml.dist b/phpunit.xml.dist
@@ -18,7 +18,9 @@
             <directory suffix=".php">./src</directory>
         </include>
         <report>
+            <xml outputDirectory="cov/xml" />
             <clover outputFile="cov/xml/clover.xml" />
+            <html outputDirectory="cov/html" />
         </report>
     </coverage>
 </phpunit>