Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use datacenter field for the IpInfo signal instead of the wrong dataCenter, deprecate IPLocation #24

Merged
merged 7 commits into from
Jan 12, 2024

Conversation

ilfa
Copy link
Member

@ilfa ilfa commented Dec 22, 2023

No description provided.

@ilfa ilfa requested a review from Orkuncakilkaya as a code owner December 22, 2023 15:12
necipallef
necipallef previously approved these changes Dec 22, 2023
Orkuncakilkaya
Orkuncakilkaya previously approved these changes Dec 22, 2023
@ilfa ilfa dismissed stale reviews from Orkuncakilkaya and necipallef via e83a6e8 January 2, 2024 16:53
Orkuncakilkaya
Orkuncakilkaya previously approved these changes Jan 3, 2024
@ilfa ilfa force-pushed the INTER-481-fixed-datacenter-name branch from 3884832 to 33f7336 Compare January 10, 2024 12:05
@ilfa ilfa changed the title Introduce datacenter field for the IpInfo signal in addition to the wrong dataCenter Use datacenter field for the IpInfo signal instead of the wrong dataCenter, deprecate IPLocation Jan 10, 2024
Orkuncakilkaya
Orkuncakilkaya previously approved these changes Jan 10, 2024
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

This PR will create a major release 🚀

3.0.0 (2024-01-12)

⚠ BREAKING CHANGES

  • IpInfo field dataCenter renamed to datacenter

Features

  • mark IPLocation as deprecated (51bcc21)
  • use datacenter instead of the wrong dataCenter (33f7336)

@ilfa ilfa merged commit 7048436 into main Jan 12, 2024
6 checks passed
@ilfa ilfa deleted the INTER-481-fixed-datacenter-name branch January 12, 2024 14:37
@ilfa
Copy link
Member Author

ilfa commented Jan 12, 2024

🎉 This PR is included in version 3.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@ilfa ilfa added the released label Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants