Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Safari 17 to Karma and remove some old browsers #150

Merged
merged 14 commits into from
Dec 11, 2023
Merged

Conversation

Finesse
Copy link
Member

@Finesse Finesse commented Oct 23, 2023

The same change as fingerprintjs/fingerprintjs#960.

Also uses a common Karma configuration provided by Broyster.

@Finesse Finesse requested a review from r-valitov October 23, 2023 12:26
@Finesse Finesse self-assigned this Oct 23, 2023
@Finesse
Copy link
Member Author

Finesse commented Oct 23, 2023

@r-valitov @xnerhu Mobile Safari 17 broke something in your code. The test case fails consistently. Please take a look and fix.

@Finesse Finesse assigned r-valitov and unassigned Finesse Oct 23, 2023
@Finesse Finesse changed the title Add Safari 17 Add Safari 17 to Karma Oct 23, 2023
@Finesse Finesse changed the title Add Safari 17 to Karma Add Safari 17 to Karma and remove some old browsers Oct 30, 2023
@Finesse Finesse force-pushed the chore/karma-safari-17 branch from 931a474 to 87eb2c9 Compare October 30, 2023 07:35
@xnerhu xnerhu requested a review from bayotop November 5, 2023 12:32
@r-valitov r-valitov assigned xnerhu and unassigned r-valitov Nov 10, 2023
@xnerhu xnerhu requested review from r-valitov and bayotop and removed request for r-valitov and bayotop November 26, 2023 16:26
src/sources/notification_permissions.ts Outdated Show resolved Hide resolved
src/sources/notification_permissions.test.ts Outdated Show resolved Hide resolved
@xnerhu xnerhu requested review from r-valitov and bayotop December 10, 2023 13:26
@xnerhu xnerhu merged commit 19dddc0 into main Dec 11, 2023
3 checks passed
@Finesse Finesse deleted the chore/karma-safari-17 branch December 11, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants