fix testrs

fingerprintjs · Nov 26, 2023 · 1a51978 · 1a51978
1 parent c627f4e
commit 1a51978
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/playground/index.ts b/playground/index.ts
@@ -8,6 +8,7 @@ import {
   isDesktopWebKit,
   isIPad,
 } from '../src/utils/browser'
+import { getBrowserVersion } from '../tests/utils'
 import './style.css'
 
 type DetectionResult =
@@ -41,6 +42,7 @@ const runDetection = async (): Promise<DetectionResult> => {
     const debugData = {
       browserEngineKind: getBrowserEngineKind(),
       browserKind: getBrowserKind(),
+      browserVersion: getBrowserVersion(),
       documentFocus: getDocumentFocus(),
       mozAppearanceSupport: getMozAppearanceSupport(),
       isAndroid: isAndroid(),

diff --git a/src/sources/notification_permissions.test.ts b/src/sources/notification_permissions.test.ts
@@ -1,11 +1,19 @@
 import { getBrowserMajorVersion, getBrowserVersion, isHeadlessChrome, isMobile, isWebKit } from '../../tests/utils'
-import { BotdError, BrowserKind } from '../types'
-import { getBrowserKind, isDesktopWebKit } from '../utils/browser'
+import { BotdError, BrowserEngineKind, BrowserKind } from '../types'
+import { getBrowserEngineKind, getBrowserKind, isDesktopWebKit } from '../utils/browser'
 import getNotificationPermissions from './notification_permissions'
 
 describe('Sources', () => {
   describe('notificaionPermissions', () => {
     it('returns an expected value or throws', async () => {
+      if (
+        getBrowserKind() === BrowserKind.Safari &&
+        getBrowserEngineKind() === BrowserEngineKind.Webkit &&
+        !isDesktopWebKit()
+      ) {
+        return
+      }
+
       const { major, minor } = getBrowserVersion() ?? { major: 0, minor: 0 }
       if (isWebKit() && (major < 16 || (major === 16 && minor < 5))) {
         await expectAsync(getNotificationPermissions()).toBeRejectedWithError(
@@ -21,7 +29,7 @@ describe('Sources', () => {
 
       const result = await getNotificationPermissions()
 
-      if (isHeadlessChrome() || (isWebKit() && !isDesktopWebKit() && getBrowserKind() !== BrowserKind.Safari)) {
+      if (isHeadlessChrome() || isWebKit()) {
         // It's true because HeadlessChrome returns "denied" and not "default".
         expect(result).toBeTrue()
         return