Endpoints ♥ Cats Effect #1003
Merged
Endpoints ♥ Cats Effect #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Switch to effect-agnostic Endpoint * Update to cats-effect 1.0.0-RC3 & cats 1.2.0. Some small fixes and refactoring * Replace default Rerunnable module with cats IO * Fix Effect definition of Try in specs * Update cats & cats-effect * Enable cancellation propagation from Finagle to effect * Enable Endpoint[F].foo syntax for all the built-in endpoints * Turn Module into trait. Remove EffectInstance
Refine Endpoint Module
…uration (#996) * replace twitter.Duration to scala.Duration * fix import ordering in spec * aliasing Duration => ScalaDuration not needed; and use Duration.Inf
Codecov Report
@@ Coverage Diff @@
## master #1003 +/- ##
==========================================
+ Coverage 83.99% 84.06% +0.07%
==========================================
Files 50 47 -3
Lines 856 885 +29
Branches 51 55 +4
==========================================
+ Hits 719 744 +25
- Misses 137 141 +4
Continue to review full report at Codecov.
|
* starts the effort to simplify artifact release * lint fix * hardcoded name and email
* replace twitter.Try[A] with Either[Throawble, A] * replace Try#toEither with old try-catch * rebase from cats-effect and replace more twitter.Try * catch error in EndpointResult#awaitOutput * fix awaitOutputUnsafe to throw an error from Option * update to scala 2.11 friendly code * remove unused header.apply and twitter.Try Eq
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'll merge these commits into master and continue the development there. Before doing this, we need to branch
rerunnableoff of master so we can continue publishing artifacts for people who aren't ready to make an immediate move.To-do (before merging):
Update: Ugh I'm terrible at merging - not sure why we end up with duplicate commits.