Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update go-state-types, adapt to QAP API changes #12445

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Sep 11, 2024

Updates go-state-types and incorporates filecoin-project/go-state-types#308 which removes "deal weight" entirely from QAP calculation since it's unnecessary. So, we inherit a signature change here for QAPowerForWeight which drops the deal weight argument.

This is on top of #12384 because it touches pledge calculation too. I'll leave this as draft until that merges. We also don't have a tagged gst with this change, and it might be best to leave this commit until @rjan90 cuts a second prerelease and pulls that in for nv24.

@rvagg rvagg requested a review from rjan90 September 11, 2024 02:25
go.mod Outdated Show resolved Hide resolved
@rjan90
Copy link
Contributor

rjan90 commented Sep 11, 2024

We also don't have a tagged gst with this change, and it might be best to leave this commit until @rjan90 cuts a second prerelease and pulls that in for nv24.

I can cut GST v0.15.0-rc1 to make the GST update here a bit cleaner. However, since there is still some time before we start the Lotus nv24 train, I suggest leaving this unmerged until we have decided if we want to ship a Lotus minor version with the indexing revamp (pending discussion we will have in a weeks time or so), to make the "cut release from master" a bit easier.

@rvagg rvagg force-pushed the rvagg/StateMinerInitialPledgeForSector branch 3 times, most recently from c55777c to b714b82 Compare September 19, 2024 10:37
@rvagg rvagg force-pushed the rvagg/StateMinerInitialPledgeForSector branch 4 times, most recently from f7244dd to 910288c Compare September 25, 2024 06:35
Base automatically changed from rvagg/StateMinerInitialPledgeForSector to master September 25, 2024 06:51
@rvagg rvagg marked this pull request as ready for review October 14, 2024 10:30
@rvagg rvagg force-pushed the rvagg/gst branch 2 times, most recently from b8f6cff to da91615 Compare October 14, 2024 10:34
@rvagg rvagg requested a review from ZenGround0 October 14, 2024 10:34
@BigLep
Copy link
Member

BigLep commented Nov 18, 2024

@rvagg :

  1. Is the next step here to get @ZenGround0 to review? If so, he will probably need a Slack ping.
  2. Is there a certain lotus release you want to have this in? (e.g., 1.32.0 for nv25)

@rvagg
Copy link
Member Author

rvagg commented Nov 19, 2024

@BigLep:

  1. Yep, probably
  2. Whatever I can get this in that's not a patch release, it's not a major change but it would be a minor breaking API change if someone's reaching in to the builtins package to use them directly

@rvagg rvagg merged commit 467c6ff into master Nov 21, 2024
82 of 83 checks passed
@rvagg rvagg deleted the rvagg/gst branch November 21, 2024 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🎉 Done
Development

Successfully merging this pull request may close these issues.

5 participants