Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add filepond-plugin-media-preview #1643

Closed
wants to merge 2 commits into from
Closed

add filepond-plugin-media-preview #1643

wants to merge 2 commits into from

Conversation

saade
Copy link
Member

@saade saade commented Feb 16, 2022

Adds preview for audios and videos using nielsboogaard/filepond-plugin-media-preview

demo

@jacksleight
Copy link
Contributor

The disablePreview() option from #1626 could also be extended to cover this, should people want to switch it off:

https://github.com/laravel-filament/filament/blob/51f309b9c23be25a417f5912e40a56a3f2274e3c/packages/forms/resources/js/components/file-upload.js#L84

allowVideoPreview: canPreview,
allowAudioPreview: canPreview,

@danharrin
Copy link
Member

We should merge both PRs to avoid merge conflicts, please organise that amongst yourselves :)

@danharrin
Copy link
Member

Since #1626 has more impact, lets merge these changes into there if @jacksleight thinks that's a good idea?

@jacksleight
Copy link
Contributor

Fine by me if @saade is happy.

@saade
Copy link
Member Author

saade commented Feb 17, 2022

Let's do it!

@jacksleight
Copy link
Contributor

Great. I've merged this into my PR, will add the new allow preview options shortly.

@saade
Copy link
Member Author

saade commented Feb 18, 2022

Gonna close this =)

@saade saade closed this Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants