Check return values when connecting to/creating a database #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug where when establishing a connection to the src database fails, the execution continues on creating the dst database and returning a 0 exit code.
This removes compilation warnings about uninitialized values.
This removes warning about deleting an object with a non-virtual destructor in the base class.
|
This is a blocker for oamg/leapp-repository#1289 |
matejmatuska
changed the title
Also implemented LibDB::close_db() which closes both the cursor and db.
matejmatuska
force-pushed
the
check-db-open-failure
branch
from
cc92780 to
766a358
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where when establishing a connection to the src database fails (because it's invalid e.g. an empty file), the execution continues on creating the dst database and returning a 0 exit code.
The other 2 commits fix compiler warnings.