Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Diffie Hellman key exchange #700

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ben-krieger
Copy link
Member

@ben-krieger ben-krieger commented Sep 26, 2024

  1. The device's secret gets set to null in an erroneous call to destroy before it is used to compute the shared secret, thus causing modPow to throw an exception.
  2. The DiffieHellman.KeyExchange type cannot reconstruct itself from an AnyType without a @JsonCreator-annotated constructor.
  3. The shared secret is sometimes 1 extra byte in length, due to the behavior of BigInteger.toBytes(). See https://stackoverflow.com/questions/24158629/biginteger-tobytearray-returns-purposeful-leading-zeros.

@ben-krieger ben-krieger changed the title Fix Diffie Hellman key exchange secret getting set null Fix Diffie Hellman key exchange Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant