Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build updates 👷 #180

Merged
merged 6 commits into from
Jan 9, 2024
Merged

Build updates 👷 #180

merged 6 commits into from
Jan 9, 2024

Conversation

mikajylha
Copy link
Collaborator

Seems like almost everyone is using this image. Most notably auto-ig-builder.

Update instructions to use the latest version of sushi too. We dont have fine grained control anymore.

docker-compose is now included in docker installations. Command is a bit different.

Mika Jylhä added 3 commits January 9, 2024 09:18
docker-compose is now included in docker installations. Command is a bit different.

This might break old docker workstation installations, but those installations should be upgrade anyways.
Seems like almost everyone is using this image. Most notably auto-ig-builder.

Update instructions to use the latest version of sushi too. We dont have fine grained control anymore.
@mikajylha mikajylha requested a review from mrinnetmaki January 9, 2024 07:53
Copy link
Collaborator

@mrinnetmaki mrinnetmaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK as it is, but I would prefer to update the _updatePublisher.sh script and let it handle the file permissions.

.github/workflows/build.yml Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
Mika Jylhä added 2 commits January 9, 2024 10:13
This was due to an old bug in _updatepublisher that has been fixed for a while.
@mikajylha mikajylha merged commit d78b2b2 into master Jan 9, 2024
1 check passed
@mikajylha mikajylha deleted the build_updates branch January 9, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants