Skip to content

Commit

Permalink
Merge pull request #172 from fhir-fi/remove-register-details
Browse files Browse the repository at this point in the history
Remove register details
  • Loading branch information
mrinnetmaki authored Oct 26, 2023
2 parents 41b11ac + 4f9c437 commit e83ea9f
Show file tree
Hide file tree
Showing 9 changed files with 58 additions and 12 deletions.
12 changes: 11 additions & 1 deletion input/fsh/examples/kantaCustodian.fsh
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ Usage: #example
* agent[+]
* role[0].coding = http://gen.kanta.fi/fikanta-cs-rolecategory#11 "Palveluntuottaja"
* who.reference = "#tuottajaorg1"
/*
* entity[0]
* role = #source
* what
Expand All @@ -101,6 +102,7 @@ Usage: #example
* system = "urn:oid:1.2.246.10"
* value = "2606155-7"
* display = "Sensotrend Oy"
*/
* target[0].reference = "EpisodeOfCare/id-for-episode-1"
* recorded = "2023-08-25T16:42:17.239+03:00"

Expand Down Expand Up @@ -147,6 +149,7 @@ Usage: #example
* agent[+]
* role[0].coding = http://gen.kanta.fi/fikanta-cs-rolecategory#11 "Palveluntuottaja"
* who.reference = "#tuottajaorg1"
/*
* entity[0]
* role = #source
* what
Expand All @@ -162,13 +165,14 @@ Usage: #example
* system = "urn:oid:1.2.246.10"
* value = "2606155-7"
* display = "Sensotrend Oy"
*/
* target[0].reference = "EpisodeOfCare/id-for-episode-1"
* recorded = "2023-08-25T16:42:17.239+03:00"

Instance: KantaDocumentMetadataFailingExample1
InstanceOf: KantaDocumentMetadata
Title: "A test example demonstrating that validation works"
Description: "This example does not have the registerType entity mandated by the Finnish Base Information Custodian profile. QA report is expected to show an error."
Description: "This example does not have the role for the agent from system urn:oid:1.2.246.537.5.40172, as would be mandated by the Finnish Base Information Custodian profile. QA report is expected to show an error."
Usage: #example
* id = "kanta-document-metadata-profile-test-example-1"
* contained[0]
Expand All @@ -182,9 +186,11 @@ Usage: #example
* type
* coding = http://terminology.hl7.org/CodeSystem/v3-ParticipationType#CST "custodian"
* text = "Rekisterinpitäjä"
/*
* role[0]
* coding = urn:oid:1.2.246.537.5.40172#1 "Julkinen"
* text = "Julkinen"
*/
* who[0]
* type = "Organization"
* identifier
Expand All @@ -198,6 +204,7 @@ Usage: #example
* agent[+]
* role[0].coding = http://gen.kanta.fi/fikanta-cs-rolecategory#11 "Palveluntuottaja"
* who.reference = "#the-same-org"
/*
* entity[0]
* role = #source
* what
Expand All @@ -206,6 +213,7 @@ Usage: #example
* system = "urn:oid:1.2.246.10"
* value = "2606155-7"
* display = "Sensotrend Oy"
*/
* target[0].reference = "EpisodeOfCare/id-for-episode-1"
* recorded = "2023-08-25T16:42:17.239+03:00"

Expand All @@ -226,6 +234,7 @@ Usage: #example
* system = "urn:oid:1.2.246.537.6.40174"
* value = "urn:oid:1.2.246.10.32213086.19.0"
* display = "Pirkanmaan hyvinvointialueen rekisterinpitäjä"
/*
* entity[0]
* role = #source
* what
Expand All @@ -241,5 +250,6 @@ Usage: #example
* system = "urn:oid:1.2.246.10"
* value = "2606155-7"
* display = "Sensotrend Oy"
*/
* target[0].reference = "EpisodeOfCare/id-for-episode-1"
* recorded = "2023-08-25T16:42:17.239+03:00"
2 changes: 2 additions & 0 deletions input/fsh/examples/provenanceCustodianIndividual.fsh
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,12 @@ Usage: #example
* system = "urn:oid:1.2.246.537.6.203"
* value = "urn:oid:1.2.246.537.28.10000222116"
* display = "Kalmanlehto Erkki"
/*
* entity[registerType]
* role = #source
* what
* identifier
* system = "urn:oid:1.2.246.537.5.40150"
* value = #10
* display = "Ammatinharjoittaja"
*/
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ Usage: #example
* system = "urn:oid:1.2.246.537.6.202"
* value = "urn:oid:1.2.246.10.32515682.10.0"
* display = "Ratinan Terveys Oy"
/*
* entity[registerType]
* role = #source
* what
Expand All @@ -35,5 +36,4 @@ Usage: #example
* system = "urn:oid:1.2.246.10"
* value = "2606155-7"
* display = "Sensotrend Oy"


*/
2 changes: 2 additions & 0 deletions input/fsh/examples/provenanceCustodianPublicHealthcare.fsh
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,12 @@ Usage: #example
* system = "urn:oid:1.2.246.537.6.40174"
* value = "urn:oid:1.2.246.10.32213086.19.0"
* display = "Pirkanmaan hyvinvointialueen rekisterinpitäjä"
/*
* entity[registerType]
* role = #source
* what
* identifier
* system = "urn:oid:1.2.246.537.5.40150"
* value = #2
* display = "Julkinen terveydenhuolto"
*/
15 changes: 15 additions & 0 deletions input/fsh/informationCustodian.fsh
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,20 @@ Description: "This is a Finnish abstract base profile for the Provenance resourc
* ^definition = "The status of the healthcare provider ([*eArkisto - Rekisteripitäjän laji*](https://koodistopalvelu.kanta.fi/codeserver/pages/classification-view-page.xhtml?classificationKey=268&versionKey=345)), i.e., whether the provider is a public or private actor. The value for the identifier SHALL be 1 for public, 2 for private."
* ^short = "Public or private occupational healthcare provider"

/* REMOVED, for now.
* We were unable to reach consensus on how the register type and the register specifier should be
* presented.
*
* This piece of profiling is left here as a reminder of the latest proposed approach. It may be
* useful when work on the topic resumes in the future.
*
* The main arguments for this approach are that no extensions are required, and that the register
* type and the register specifier seem to be entities (rather than agents, at least).
* The main arguments against this proposal are that this approach puts codeable information in
* an identifer, and that the register, especially with the roles available for it, still does not
* seem to be a good fit for the registry information.
*
* entity 1..*
* entity ^slicing.discriminator.type = #value
Expand Down Expand Up @@ -78,6 +92,7 @@ Description: "This is a Finnish abstract base profile for the Provenance resourc
* entity[registerSpecifierCustomerWithoutId].what.identifier.system = "urn:oid:1.2.246.537.30"
* ^definition = "A customer without a Finnish person or business ID as a customer of an occupational healthcare provider."
* ^short = "Customer of private occupational healthcare"
*/

Profile: FiBaseInformationCustodianPublic
Parent: FiBaseInformationCustodian
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
{:.dragon}
This example refers to extensions defined in another implementation guide, the
[FinnishScheduling R4](https://simplifier.net/finnishschedulingr4/) IG, and has errors in the
[QA Report](qa.html) for this guide. The schedulinig IG is about to be updadted and the
canonical urls defined for the extensions may change, at least to have a `https` protocol instead
of `http`.
Note that this example refers to extensions defined in another implementation guide, the
[FinnishScheduling R4](https://simplifier.net/finnishschedulingr4/) IG. The schedulinig IG is about
to be updadted and the canonical urls defined for the extensions may change, at least to have a
`https` protocol instead of `http`.
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,22 @@ For details, please refer to the
specification, version 4.66 or later, chapters 2.2.17, 2.4.21, and 2.4.22.

These details are expressed with the Provenance resource conforming to this profile. Information
custodian is the `.agent` and the registry is specified with one or two `.entity` instances.
custodian is the `.agent`.

{:.stu-note}
The working group was not able to reach consensus on how to present the details of the register
(the type of register, *reksterin tyyppi* and the register specifier, *rekisterin tarkenne*). One
option is to use extensions to the information custodian `.agent` or even to the Provenance
resource instance (see
[the ballot version](https://hl7.fi/fhir/finnish-base-profiles/1.0-rc15/StructureDefinition-fi-base-provenance.html)
as one example). Another proposed approach is to
encode this information in `.entity` instances (see
[version 1.0.0-rc21](https://hl7.fi/fhir/finnish-base-profiles/1.0-rc21/StructureDefinition-fi-base-information-custodian.html)
for details). See also the
[discussion thread](https://chat.fhir.org/#narrow/stream/179247-Security-and-Privacy/topic/Specific.20register.20in.20Provenance/near/385117093)
on chat.fhir.org and the GitHub issues
[#88](https://github.com/fhir-fi/finnish-base-profiles/issues/88),
[#135](https://github.com/fhir-fi/finnish-base-profiles/issues/135),
[#141](https://github.com/fhir-fi/finnish-base-profiles/issues/141), and
[#163](https://github.com/fhir-fi/finnish-base-profiles/issues/163).
Implementer feedback is appreciated on how to continue work on the topic.
4 changes: 2 additions & 2 deletions publication-request.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"package-id" : "hl7.fhir.fi.base",
"version" : "1.0.0-rc18",
"path" : "https://hl7.fi/fhir/finnish-base-profiles/1.0-rc18",
"version" : "1.0.0-rc23",
"path" : "https://hl7.fi/fhir/finnish-base-profiles/1.0-rc22",
"mode" : "milestone",
"status" : "qa-preview",
"sequence" : "STU 1",
Expand Down
2 changes: 1 addition & 1 deletion sushi-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ name: FinnishBaseProfiles
title: Finnish Base Profiles
description: A core set of FHIR resources profiled for use in Finland, published and maintained by HL7 Finland
status: draft # draft | active | retired | unknown
version: 1.0.0-rc20
version: 1.0.0-rc23
fhirVersion: 4.0.1 # https://www.hl7.org/fhir/valueset-FHIR-version.html
copyrightYear: 2022+
releaseLabel: qa-preview # ci-build | draft | qa-preview | ballot | trial-use | release | update | normative+trial-use
Expand Down

0 comments on commit e83ea9f

Please sign in to comment.