Improvements to three point filtering #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ee options, and three point can be changed in real time.
|
I'd say it would be an acceptable solution to just pop up a message that says "this will only apply after restart". Not sure about having that extra branch/uniform on everything. I'll just merge this and see what I can do about it. |
|
Made it so it only adds that part when it's enabled. Runtime switching is still supported, I just had to nuke the entire shader and color combiner cache for that to work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented texture filtering setting with a dropdown showing all three options, and three point can now be changed in real time. Also non-filtered textures are respected in three point mode. Fixes: #39
It's probably not ideal the fact that the three point shader code is now always present, but tried other approaches like deleting all programs and clearing the shader pool when changing modes without success.