Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log errors on the list certificates request #110

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

nizar-m
Copy link
Contributor

@nizar-m nizar-m commented Feb 28, 2024

fixes #109

Currently the errors on the list certificates request during certificate renewal is not logged. The PR fixes this issue.

@fffonion
Copy link
Owner

@nizar-m thank you!

@fffonion fffonion merged commit 6c9760f into fffonion:master Feb 28, 2024
5 checks passed
kikito pushed a commit to Kong/kong that referenced this pull request Apr 23, 2024
### Summary

#### [0.13.0] - 2024-03-28
##### bug fixes
- **autossl:** log the errors on the list certificates request ([#110](fffonion/lua-resty-acme#110)) [6c9760f](fffonion/lua-resty-acme@6c9760f)

#### features
- **autossl:** add option to delete none whitelisted domains in certificate renewal ([#112](fffonion/lua-resty-acme#112)) [1bbf39c](fffonion/lua-resty-acme@1bbf39c)

Signed-off-by: Aapo Talvensaari <[email protected]>
bungle added a commit to Kong/kong that referenced this pull request Apr 23, 2024
### Summary

#### [0.13.0] - 2024-03-28
##### bug fixes
- **autossl:** log the errors on the list certificates request ([#110](fffonion/lua-resty-acme#110)) [6c9760f](fffonion/lua-resty-acme@6c9760f)

#### features
- **autossl:** add option to delete none whitelisted domains in certificate renewal ([#112](fffonion/lua-resty-acme#112)) [1bbf39c](fffonion/lua-resty-acme@1bbf39c)

Signed-off-by: Aapo Talvensaari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

During renewal, errors on list() operation from consul storage is not logged: instead results in runtime error
2 participants