Create a new test with an strange Sequences issue

[rocboronat]

Test public void getSequences_shouldNotCrash_whenPassingAQuitNowText1() throws InterruptedException { String text = "@Twinx@ Texie@sabertooth89 great Quit!!"; List<Sequence> sequences = new MentionDetector(text).getSequences(); assertThat(sequences).hasSize(1); }

... right now, it breaks, 'cause it returns two Sequences instead of only one.

[EsteveAguilera]

I'm adding some info I've found when debugging the test you added:

parseMention() detects 3 mentions:

• (at)Twinx
• (at)Texie
• (at)sabertooth89

getSequences() detects 2 sequences:

• 0-12 -> (at)Twinx(at) Texie
• 13-26 -> (at)sabertooth89

You say that it should return 1 sequence instead of 2 so the real mention/sequence should be just (at)Twinx. Am I right?

[rocboronat]

Mmmm that's what I thought three years ago, haha! Now I think that "@ Texie" shouldn't be considered a mention. What do you think? 😄

[EsteveAguilera]

Ouch, I didn't realize this was a 3 y.o issue 😅

Just to see what others consider a mention, and what doesn’t, I’ve done a test on TW, and found something different...

And I agree with TW, a mention is a mention, you type it wrong? Sorry, but no mention....

[rocboronat]

Hahaha good test! Then we should edit the library to catch this case.

Sounds not that easy, by the way, hahaha!

[EsteveAguilera]

🤔This sounds me like a new issue. Maybe something like "change the definition of mention".
What do you think @rocboronat?

[rocboronat]

That's true! :·)

[rocboronat]

Let's move the discussion to #10