You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
My suggestion is to simply do the same Twitter does. Let's mimic the big ones!
About the last question, our beloved app allows starting and ending dots (.) and hyphens (-). If that doesn't meet Twitter needs, we should change the app's nick format to avoid those starting and ending dots and hyphens, but it would only apply to the new accounts.
By the way, this library has only ten favs. I don't know if it worths the effort of taking that punctuation marks in account. It wasn't the game changer that we expected 😂
Ok... I will not change the starting dots and hyphens, at least by now. Maybe someday on the future, we will have a lot of free time and will add some options like enableDotsOnNickNames
So... I think that those examples will cover the cases we need to reproduce on tests:
@nick.-> Mention with username nick. @-nick -> Mention with username -nick @nick! -> Menion with username nick
@!nick -> No mention @nick@ -> No mention @ nick -> No mention nick@nick -> No mention
On #8 we found that the current definition of mention might not be the best one.
I'm opening this issue to discuss which one is the best definition of mention, so we can implement it in the library!
Some things we found on #8:
@Twinx@
-> Not a mention@ Texie
-> Not a mentionTexie@sabertooth89
-> No mention hereAnd a question: should we allow punctuations marks or some symbols before the @ and after the username?
The text was updated successfully, but these errors were encountered: