Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the definition of mention #10

Open
EsteveAguilera opened this issue Feb 17, 2019 · 3 comments
Open

Change the definition of mention #10

EsteveAguilera opened this issue Feb 17, 2019 · 3 comments

Comments

@EsteveAguilera
Copy link
Member

On #8 we found that the current definition of mention might not be the best one.

I'm opening this issue to discuss which one is the best definition of mention, so we can implement it in the library!

Some things we found on #8:

@Twinx@ -> Not a mention
@ Texie -> Not a mention
Texie@sabertooth89 -> No mention here

And a question: should we allow punctuations marks or some symbols before the @ and after the username?

@rocboronat
Copy link
Member

My suggestion is to simply do the same Twitter does. Let's mimic the big ones!

About the last question, our beloved app allows starting and ending dots (.) and hyphens (-). If that doesn't meet Twitter needs, we should change the app's nick format to avoid those starting and ending dots and hyphens, but it would only apply to the new accounts.

By the way, this library has only ten favs. I don't know if it worths the effort of taking that punctuation marks in account. It wasn't the game changer that we expected 😂

@EsteveAguilera
Copy link
Member Author

Ok... I will not change the starting dots and hyphens, at least by now. Maybe someday on the future, we will have a lot of free time and will add some options like enableDotsOnNickNames

So... I think that those examples will cover the cases we need to reproduce on tests:

@nick.-> Mention with username nick.
@-nick -> Mention with username -nick
@nick! -> Menion with username nick

@!nick -> No mention
@nick@ -> No mention
@ nick -> No mention
nick@nick -> No mention

Am I right? Did I miss something?

@rocboronat
Copy link
Member

You missed nothing! The test with the ! will be great to have ☺

@alorma alorma mentioned this issue Feb 19, 2019
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants