-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add wallet messaging #53
Conversation
Co-authored-by: James Riehl <[email protected]>
I can't poetry install |
We certainly don't claim to support Python 3.12 yet. Can you try with an earlier version for now and then we can raise an issue to fix this? Actually up until this PR, we still specified python ">=3.8, <3.12", but this is an annoying constraint to enforce when installing with other packages, so I think "^3.8" is better and maybe this will also push us to stay up to date with the latest Python versions. |
When forcing 3.11.6 with all extensions installed I still get errors but this time from coincurve (didn't we got rid of that a while ago?) Also my Poetry installation strangely is hardwired to 3.12 and when using brew on Mac I am not able to specify which version to install (that poetry uses for installations) Meaning that when I install Poetry itself on my system it implicitly installs and uses the latest registered python version which is 3.12. |
We did remove that from CosmPy but To fix this on a Mac, you should be able to run @ejfitzgerald Any chance we could do the same tricks to pull this Update: Seems that this is doable, but not particularly easy and probably won't make it into this PR. |
Following the instructions on their page (docs) for MacOS: xcode-select --install
brew install autoconf automake libffi libtool pkg-config python I was able to install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have just a couple of remarks but all in all it's very good!
It works as intended (when the correct environment is present) and I am curious to see this in action in more complex agent scenarios. The only downside is that this implementation does not seamlessly fit into the existing uagents codebase or looking at it from a different angle it's the perfect example for an add-on/extra module.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good from my side now!
Adds wallet messaging as an optional feature. This means it needs to be installed with:
pip install uagents[wallet]
pip install uagents[all]
poetry install -E wallet
poetry install -E all
Adds
on_wallet_message
decorator and uses babble client to send and retrieve messages from wallet messaging server.Example
15-wallet-messaging
demonstrates the new feature.