Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: better exception handling #133

Merged
merged 6 commits into from
Aug 31, 2023
Merged

feat: better exception handling #133

merged 6 commits into from
Aug 31, 2023

Conversation

jrriehl
Copy link
Contributor

@jrriehl jrriehl commented Aug 24, 2023

Generally tried to ensure we catch exceptions wherever a task is awaited or created.

@jrriehl jrriehl changed the title chore: handle exceptions in message handlers feature: better exception handling Aug 24, 2023
@jrriehl jrriehl changed the title feature: better exception handling feat: better exception handling Aug 24, 2023
Archento
Archento previously approved these changes Aug 25, 2023
Copy link
Member

@Archento Archento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The added try-catch blocks all look good to me.

I'm just wondering if catching those specific errors at the agent level and forwarding them to the logger is enough or if we should also try-catch at a deeper level like context.py:L245-254.
Just an idea, otherwise I think it's a good start :)

@jrriehl
Copy link
Contributor Author

jrriehl commented Aug 30, 2023

The added try-catch blocks all look good to me.

I'm just wondering if catching those specific errors at the agent level and forwarding them to the logger is enough or if we should also try-catch at a deeper level like context.py:L245-254. Just an idea, otherwise I think it's a good start :)

Good point, I added some exception handling here as well.

Archento
Archento previously approved these changes Aug 30, 2023
Copy link
Member

@Archento Archento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's what I had in mind! Good stuff :)

@jrriehl jrriehl merged commit 3c41113 into main Aug 31, 2023
7 checks passed
@jrriehl jrriehl deleted the chore/exception-handling branch August 31, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants