-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: better exception handling #133
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The added try-catch blocks all look good to me.
I'm just wondering if catching those specific errors at the agent level and forwarding them to the logger is enough or if we should also try-catch at a deeper level like context.py:L245-254.
Just an idea, otherwise I think it's a good start :)
Good point, I added some exception handling here as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's what I had in mind! Good stuff :)
Generally tried to ensure we catch exceptions wherever a task is awaited or created.