Upgrade dependencies

 - Drop PHP5 support, require 7.1 as minimal
 - Add compatibility with Symfony4
 - Add PHP 7.2 support

.travis.yml

@@ -1,9 +1,8 @@
 language: php
 
 php:
-    - 5.6
-    - 7.0
-    - hhvm
+    - 7.1
+    - 7.2
 
 before_script:
   - composer install --no-interaction

composer.json

@@ -21,12 +21,13 @@
     },
     "minimum-stability": "stable",
     "require": {
-        "php": ">=5.6.0",
-        "symfony/http-foundation": "^3.0",
-        "symfony/validator": "^3.0"
+        "php": ">=7.1.0",
+        "symfony/http-foundation": "^3.3|^4.0",
+        "symfony/validator": "^3.3|^4.0"
     },
     "require-dev": {
         "phpunit/phpunit": "^5.3",
-        "symfony/framework-bundle": "^3.0"
+        "symfony/framework-bundle": "^3.3|^4.0",
+        "symfony/var-dumper": "^4.0"
     }
 }

examples/App/config.yml

@@ -17,4 +17,5 @@ framework:
 
 services:
   app_controller:
-    class: 'Fesor\RequestObject\Examples\App\AppController'
+    class: 'Fesor\RequestObject\Examples\App\AppController'
+    public: true

src/Bundle/DependeyInjection/RequestObjectExtension.php

@@ -6,9 +6,9 @@
 use Fesor\RequestObject\HttpPayloadResolver;
 use Fesor\RequestObject\PayloadResolver;
 use Fesor\RequestObject\RequestObjectBinder;
+use Symfony\Component\DependencyInjection\ChildDefinition;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\Definition;
-use Symfony\Component\DependencyInjection\DefinitionDecorator;
 use Symfony\Component\DependencyInjection\Extension\Extension;
 use Symfony\Component\DependencyInjection\Reference;
 
@@ -27,9 +27,11 @@ private function registerPayloadResolver(ContainerBuilder $container)
         $definition->setAbstract(true);
         $container->setDefinition('request_object.payload_resolver', $definition);
 
-        $implDefinition = new DefinitionDecorator('request_object.payload_resolver');
+        $implDefinition = new ChildDefinition('request_object.payload_resolver');
         $implDefinition->setClass(HttpPayloadResolver::class);
         $container->setDefinition('request_object.payload_resolver.http', $implDefinition);
+
+        $container->setAlias(PayloadResolver::class, 'request_object.payload_resolver.http');
     }
 
     private function registerRequestBinder(ContainerBuilder $container)

src/RequestObjectBinder.php

@@ -73,7 +73,7 @@ public function bind(Request $request, callable $action)
         $requestObject->setPayload($payload);
         if (array_key_exists('errors', $matchedArguments)) {
             $request->attributes->set($matchedArguments['errors']->name, $errors);
-        } elseif (0 !== count($errors)) {
+        } elseif ($errors && 0 !== $errors->count()) {
             return $this->providerErrorResponse($requestObject, $errors);
         }
     }