Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(generator-cli): support title property on readme features #1840

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dsinghvi
Copy link
Member

Short description of the changes made

Adds title so we can control titles on features in README generation.

What was the motivation & context behind this PR?

Want to add custom title to a feature in the TypeScript SDK.

How has this PR been tested?

Yup, see newly added testcase.

Copy link

vercel bot commented Nov 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
rbac.ferndocs.com ❌ Failed (Inspect) Nov 19, 2024 10:12pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
fern-shell ⬜️ Ignored (Inspect) Nov 19, 2024 10:12pm

Copy link

Copy link

github-actions bot commented Nov 19, 2024

📦 Next.js Bundle Analysis for fern-platform-monorepo

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

github-actions bot commented Nov 19, 2024

PR Preview

Copy link

github-actions bot commented Nov 19, 2024

Playwright test results

passed  97 passed
flaky  1 flaky
skipped  3 skipped

Details

stats  101 tests across 10 suites
duration  1 minute, 22 seconds
commit  75429ba

Flaky tests

chromium › forward-proxy/nextjs.spec.ts › capture the flag

Skipped tests

chromium › posthog.spec.ts › Posthog loads successfully
chromium › proxy.spec.ts › multipart-form upload
chromium › proxy.spec.ts › json request

Copy link

Copy link

@dsinghvi dsinghvi had a problem deploying to Preview - dashboard-dev.buildwithfern.com November 19, 2024 23:37 — with GitHub Actions Failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants