fix: Algolia Search Visual Papercuts #1712
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
RohinBhargava
had a problem deploying
to
Preview - app-dev.buildwithfern.com
GitHub Actions
Error
RohinBhargava
had a problem deploying
to
Preview - app.buildwithfern.com
GitHub Actions
Error
RohinBhargava
had a problem deploying
to
Preview - app-dev.buildwithfern.com
GitHub Actions
Failure
RohinBhargava
had a problem deploying
to
Preview - app.buildwithfern.com
GitHub Actions
Failure
abvthecity
approved these changes
Oct 24, 2024
abvthecity
reviewed
Oct 24, 2024
| const markdownTree = getMarkdownSectionTree(rawMarkdown, title); | ||
| const description = truncateToBytes( | ||
| frontmatter.description ?? frontmatter.subtitle ?? markdownTree.content ?? content, |
There was a problem hiding this comment.
this is going to delete the content and prefer the frontmatter instead. you probably want to concat all of these instead. see: https://github.com/fern-api/fern-platform/blob/main/packages/ui/fern-docs-search-server/src/algolia/records/generateMarkdownRecords.ts#L32-L53
There was a problem hiding this comment.
I actually mean to truncate -- since there are section records, the page no longer needs these. Customer suggested we use the frontmatter description or subtitle, here
fern-bot
had a problem deploying
to
Preview - app.buildwithfern.com
GitHub Actions
Failure
fern-bot
had a problem deploying
to
Preview - app-dev.buildwithfern.com
GitHub Actions
Failure
fern-bot
had a problem deploying
to
Preview - app-dev.buildwithfern.com
GitHub Actions
Failure
fern-bot
had a problem deploying
to
Preview - app.buildwithfern.com
GitHub Actions
Failure
abvthecity
approved these changes
Oct 26, 2024
RohinBhargava
had a problem deploying
to
Preview - app.buildwithfern.com
GitHub Actions
Failure
RohinBhargava
had a problem deploying
to
Preview - app-dev.buildwithfern.com
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes FER-3414
Short description of the changes made
Addresses:
To be done:
What was the motivation & context behind this PR?
How has this PR been tested?
Screen.Recording.2024-10-24.at.7.10.01.PM.mov