Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added useful editions to animation plotting #8

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rgerru
Copy link

@rgerru rgerru commented Sep 11, 2023

Added vertical and horizontal limits to animation, as well as the possibility of plotting flux surfaces and changing the cmap of animation.

Added vertical and horizontal limits to animation, as well as the possibility of plotting flux surfaces and changing the cmap of animation.
@rgerru rgerru closed this Sep 11, 2023
@rgerru rgerru reopened this Sep 11, 2023
@rgerru rgerru closed this Sep 11, 2023
@rgerru rgerru reopened this Sep 11, 2023
Copy link
Collaborator

@gregordecristoforo gregordecristoforo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just have this small comment about the plotting limits but feel free to merge it.

@@ -267,16 +281,22 @@ def animate_pcolormesh(

# Add title and axis labels
ax.set_title(variable)
if None not in (xmin, xmax):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can pass None to ax.set_xlim:

ax.set_xlim(None, 10)

Passing None leaves the limit unchanged. You could remove the if None not in (min, max) then.

@rgerru
Copy link
Author

rgerru commented Sep 12, 2023

It should be edited now. I am not sure why the commit appears like 8 hours ago when I did it right now. It might be something related with local times.

@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@gregordecristoforo
Copy link
Collaborator

@rgerru Could you run black for code formatting on the files test_animate.py and plotting.py? Once all checks pass you can go ahead and merge it.

@rgerru
Copy link
Author

rgerru commented Sep 13, 2023

Hi Gregor,

I have never used black or any tool to homogenize the formating of files. I fear it is something related with my code editor that changed some formating. Could you enforced it from your end? As it seems like you know what is failing. I have already checked indentations and they seem coherent with the rest of the code when opened with my editor, so it must be something related with how the editor opens and then saves the file back.

@gregordecristoforo
Copy link
Collaborator

I submitted a PR to rgerru:main: rgerru#1
Once you merge this PR the code formatting issues of this PR should be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants