fix: openPod should redirect to the pod's view

was using invalid encoding scheme for the namespace fixes podman-desktop#5774 Signed-off-by: Florent Benoit <[email protected]>
feloy · Feb 5, 2024 · 3a1ad68 · 3a1ad68
1 parent 14705c7
commit 3a1ad68
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/packages/renderer/src/lib/pod/DeployPodToKube.spec.ts b/packages/renderer/src/lib/pod/DeployPodToKube.spec.ts
@@ -497,12 +497,12 @@ test('Should display Open pod button after successful deployment', async () => {
 
   await waitFor(() =>
     kubernetesCreatePodMock.mockResolvedValue({
-      metadata: { name: 'hello', namespace: 'default' },
+      metadata: { name: 'foobar/api-fake-cluster.com:6443', namespace: 'default' },
     }),
   );
   await waitFor(() =>
     kubernetesReadNamespacedPodMock.mockResolvedValue({
-      metadata: { name: 'hello' },
+      metadata: { name: 'foobar/api-fake-cluster.com:6443' },
       status: {
         phase: 'Running',
       },
@@ -522,5 +522,5 @@ test('Should display Open pod button after successful deployment', async () => {
   expect(openPodButton).toBeEnabled();
 
   await fireEvent.click(openPodButton);
-  expect(router.goto).toHaveBeenCalledWith(`/pods/kubernetes/hello/default/logs`);
+  expect(router.goto).toHaveBeenCalledWith(`/pods/kubernetes/foobar%2Fapi-fake-cluster.com%3A6443/default/logs`);
 });
diff --git a/packages/renderer/src/lib/pod/DeployPodToKube.svelte b/packages/renderer/src/lib/pod/DeployPodToKube.svelte
@@ -141,7 +141,9 @@ function openPodDetails(): void {
   if (!createdPod?.metadata?.name || !defaultContextName) {
     return;
   }
-  router.goto(`/pods/kubernetes/${encodeURI(createdPod.metadata.name)}/${encodeURI(defaultContextName)}/logs`);
+  router.goto(
+    `/pods/kubernetes/${encodeURIComponent(createdPod.metadata.name)}/${encodeURIComponent(defaultContextName)}/logs`,
+  );
 }
 
 function openRoute(route: V1Route) {